Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

no-var-keyword doesn't reject export var statements #1256

Closed
giladgray opened this issue May 16, 2016 · 0 comments
Closed

no-var-keyword doesn't reject export var statements #1256

giladgray opened this issue May 16, 2016 · 0 comments
Labels
Difficulty: Easy P2 Status: Work In Progress Type: Bug
Milestone
TSLint v4.0

Comments

@giladgray
Copy link

giladgray commented May 16, 2016 •
edited
Loading

Bug Report

  • TSLint version: 3.10.1
  • TypeScript version: 1.8.10
  • Running TSLint via: Node.js API & gulp-tslint

TypeScript code being linted

export var OverlayFactory = React.createFactory(Overlay);

with tslint.json:

"no-var-keyword": true,

Actual behavior

Does not reject var keyword

Expected behavior

Would reject var keyword.

Removing the export keyword (var name = ...) does lint correctly.
@adidahiya adidahiya added the P2 label Jun 8, 2016
IllusionMH added a commit to IllusionMH/tslint that referenced this issue Aug 9, 2016
@IllusionMH
Update no-var-keyword to dissalow var in export statements (fixes pal…
b4c2264 
…antir#1256)
@IllusionMH IllusionMH mentioned this issue Aug 9, 2016
Merged
@adidahiya adidahiya added this to the TSLint v4.0 milestone Aug 10, 2016
jkillian pushed a commit that referenced this issue Aug 23, 2016
@IllusionMH @jkillian
Update no-var-keyword to dissalow var in export statements (fixes #1256…
e0bd8c9 
…) (#1471)
soniro pushed a commit to soniro/tslint that referenced this issue Aug 31, 2016
@IllusionMH
Update no-var-keyword to dissalow var in export statements (fixes pal…
873fec1 
…antir#1256) (palantir#1471)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Difficulty: Easy P2 Status: Work In Progress Type: Bug
Projects
None yet
Milestone
TSLint v4.0
Development

No branches or pull requests
2 participants
@giladgray @adidahiya