false positive: no-shadowed-variable

[unional]

tslint: 3.7.1

export default function applyMixins(
    derivedCtor: new (...args: any[]) => any,
    baseCtors: Array<new (...args: any[]) => any>): void {
    // ...
    });
};

error: shadowed variable: 'args'

[bencoveney]

Have another set of reproduction steps if it helps. Presumably the same issue:

class MyClass { };

declare type MyConstructor = new (myVariable: any) => MyClass;

function MyFunction(constructor: MyConstructor)
{
    const myVariable = 1;
    console.log(myVariable);
}

tslint version 3.13.0

[adidahiya]

@bencoveney which identifier is reported as shadowed in that example?

[bencoveney]

Sorry, the error message is:

Shadowed variable: 'myVariable'

[IllusionMH]

@adidahiya, @jkillian looks like parameters from ConstrustorType and FunctionType nodes shouldn't be added to scope. What do you think on this kind of fix?

[adidahiya]

@IllusionMH sounds reasonable. I assume that those syntax kinds are distinct from constructor/function declarations? i.e. this would still produce a lint failure:

function MyFunction(x: any) {
  let x: string;
      ^ Shadowed variable 'x'
}

[jkillian]

Fixed by #1482