Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Allow PascalCase for "variable-name" rule #1079

Closed
JoshuaKGoldberg opened this issue Apr 2, 2016 · 2 comments
Closed

Allow PascalCase for "variable-name" rule #1079

JoshuaKGoldberg opened this issue Apr 2, 2016 · 2 comments
Labels
P2 Status: Accepting PRs Type: Rule Suggestion
Milestone
TSLint 3.8

Comments

@JoshuaKGoldberg
Copy link
Contributor

It would be nice to have this in addition to camelCase and UPPER_CASE.

It would also be nice if you could assign me to implement it :)
@adidahiya
Copy link
Contributor

sure thing, go for it @JoshuaKGoldberg!

(I can only officially assign someone to the GH issue if they're part of the palantir org)

@jkillian
Copy link
Contributor

jkillian commented Apr 2, 2016

👍 With Javascript constructor functions as first class objects, PascalCased names are going to exist in legit code. The rule will still disallow stuff like "crazyNamed_vairable" or "what-isThis_naming" type things.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Apr 11, 2016
Merged
jkillian pushed a commit that referenced this issue Apr 15, 2016
@jkillian
Added "allow-pascal-case" to variable-name-rule (#1107)
7dc17de 
Fixes #1079
@adidahiya adidahiya added this to the TSLint 3.8 milestone Apr 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P2 Status: Accepting PRs Type: Rule Suggestion
Projects
None yet
Milestone
TSLint 3.8
Development

No branches or pull requests
3 participants
@adidahiya @jkillian @JoshuaKGoldberg