Upgrade Gradle wrapper to the latest version #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
|
Was doing this change on https://github.palantir.build/excavator-checks/excavator-gradle/pull/3417 as well, but excavator pushed over my commits 😬 Moved the change request to this PR instead |
CRogers
reviewed
Aug 12, 2022
| } | ||
|
|
||
| /** | ||
| * Still support old consumers which don't declare a required usage, such as gradle-docker's docker configuration. |
There was a problem hiding this comment.
This is a big wat - no idea what this is actually doing. Since we don't really use gradle-docker internally, at least not for anything that matters, I'm ok attempting to remove this.
CRogers
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Upgrading to gradle wrapper version
7.5.After a lot of digging up and trying to make sense of how attribute matching works in variant disambiguation, looks like there were changes in gradle
>=7.4that make variant resolution a bit different.BLUF is that a custom disambiguation rule we added for compat with clients on older versions is causing trouble in variant resolution on consumers after gradle
7.4. Removing this custom rule solves the issue, and I don't see / wasn't able to find a reason for us to have it.After this PR
==COMMIT_MSG==
Gradle wrapper is updated to latest version
7.5==COMMIT_MSG==
Possible downsides?