Refactor guide line layer - Pass 1 #2666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assert.strictEqual(gll.width(), SVG_WIDTH, "accepted all offered width"); | ||
| assert.strictEqual(gll.height(), SVG_HEIGHT, "accepted all offered height"); | ||
| svg.remove(); | ||
| describe("Interactive Components", () => { |
There was a problem hiding this comment.
GuideLineLayer isn't interactive, since it doesn't include an Interaction, so I don't think it belongs in this describe().
There was a problem hiding this comment.
Then let's find an umbrella for all of them. Layer Components ? It should include
dragBoxLayerTests.tsguidelinesLayerTests.tsselectionBoxLayerTests.tsxDragBoxLayerTests.tsyDragBoxLayerTests.ts
| describe("Rendering (vertical)", () => { | ||
| const SVG_WIDTH = 400; | ||
| const SVG_HEIGHT = 300; | ||
| const GUIDE_LINE_CLASS = "." + "guide-line"; |
There was a problem hiding this comment.
Can we look into setting up a TSLint rule for having const on variables with ALL_CAPS naming?
|
Opened palantir/tslint#604 |
|
I will convert back to |
aicioara
added a commit
that referenced
this pull request
Aug 24, 2015
Refactor guide line layer - Pass 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2623
I will be doing 2 passes because I will get more context (and better sense of best practices) by refactoring other files. However, please flag anything that seems unusual.
As part of this:
beforeEach()clausesbeforeEach()es