Refactor drag box layer tests - Part 1 #2655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let bounds = dbl.bounds(); | ||
| assert.deepEqual(bounds.topLeft, startPoint, "top-left point was set correctly"); | ||
| assert.deepEqual(bounds.bottomRight, endPoint, "bottom-right point was set correctly"); | ||
| describe("DragBoxLayer - basics", () => { |
| let target = dbl.background(); | ||
| TestMethods.triggerFakeDragSequence(target, targetPoint, targetPoint); | ||
| afterEach(() => { | ||
| svg.remove(); |
There was a problem hiding this comment.
this will get called even the test fails; I remember being told that this is not desired
|
just wondering, is it necessary to put |
|
Amazing review. Thank you very much. Managed to apply suggestions from here to my other refactor PRs. |
|
|
||
| it("can get and set the detection radius", () => { | ||
| assert.strictEqual(dbl.detectionRadius(), 3, "there is a default detection radius"); | ||
| assert.doesNotThrow(() => dbl.detectionRadius(4), Error, "can set detection radius before anchoring"); |
There was a problem hiding this comment.
doesNotThrow(). I got tricked by this 3 times while refactoring. The signature is a bit weird.
…ame component on all drag events
aicioara
added a commit
that referenced
this pull request
Aug 24, 2015
Refactor drag box layer tests - Part 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2623
I will be doing multiple passes because I will get more context (and better sense of best practices) by refactoring other files. However, please flag anything that seems unusual.
As part of this:
beforeEach()clausesbeforeEach()esafterEach()to save some LOCs[NOQE] as no JS changes