Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix breadcrumbs collapsed a11y failure #6985

Merged
merged 7 commits into from
Oct 8, 2024
Merged

fix breadcrumbs collapsed a11y failure #6985

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
992a5b0
fix a11y issue
bvandercar-vt Sep 18, 2024
028af69
Merge branch 'develop' into bvandercar/breadcrumbs-collapsed-a11y-fix
bvandercar-vt Sep 18, 2024
789b5f7
Merge branch 'develop' into bvandercar/breadcrumbs-collapsed-a11y-fix
bvandercar-vt Sep 23, 2024
12fdbc6
Merge branch 'develop' into bvandercar/breadcrumbs-collapsed-a11y-fix
bvandercar-vt Oct 3, 2024
8551982
add overflowButtonProps
bvandercar-vt Oct 3, 2024
e2a0b96
whitespace
bvandercar-vt Oct 3, 2024
e446c09
Merge branch 'develop' into bvandercar/breadcrumbs-collapsed-a11y-fix
ggdouglas Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/core/src/components/breadcrumbs/_breadcrumbs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@
Breadcrumbs

Markup:
<ul class="#{$ns}-breadcrumbs">
<ol class="#{$ns}-breadcrumbs">
<li><a class="#{$ns}-breadcrumbs-collapsed" href="#"></a></li>
<li><a class="#{$ns}-breadcrumb #{$ns}-disabled">Folder one</a></li>
<li><a class="#{$ns}-breadcrumb" href="#">Folder two</a></li>
<li><a class="#{$ns}-breadcrumb" href="#">Folder three</a></li>
<li><span class="#{$ns}-breadcrumb #{$ns}-breadcrumb-current">File</span></li>
</ul>
</ol>

Styleguide breadcrumbs
*/
Expand All @@ -30,7 +30,7 @@ Styleguide breadcrumbs
margin: 0;
padding: 0;

// descendant selector because nothing should come between ul and li
// descendant selector because nothing should come between ol and li
> li {
align-items: center;
display: flex;
Expand Down
9 changes: 7 additions & 2 deletions packages/core/src/components/breadcrumbs/breadcrumbs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export class Breadcrumbs extends AbstractPureComponent<BreadcrumbsProps> {
<OverflowList
collapseFrom={collapseFrom}
minVisibleItems={minVisibleItems}
tagName="ul"
tagName="ol"
ggdouglas marked this conversation as resolved.
Show resolved Hide resolved
{...overflowListProps}
className={classNames(Classes.BREADCRUMBS, overflowListProps.className, className)}
items={items}
Expand Down Expand Up @@ -127,7 +127,12 @@ export class Breadcrumbs extends AbstractPureComponent<BreadcrumbsProps> {
content={<Menu>{orderedItems.map(this.renderOverflowBreadcrumb)}</Menu>}
{...popoverProps}
>
<span className={Classes.BREADCRUMBS_COLLAPSED} />
<span
aria-label="collapsed breadcrumbs"
ggdouglas marked this conversation as resolved.
Show resolved Hide resolved
className={Classes.BREADCRUMBS_COLLAPSED}
role="button"
tabIndex={0}
/>
</Popover>
</li>
);
Expand Down