various lint fixes

palantir · adidahiya · May 29, 2020 · May 27, 2020 · May 27, 2020 · May 27, 2020
commit 6e291e675ac33bfbe2770c5584bb978ef78ddd8f
diff --git a/.prettierignore b/.prettierignore
@@ -3,3 +3,4 @@ generated/
 lib/
 dist/
 /site/
+*.scss
diff --git a/packages/core/src/blueprint-hi-contrast.scss b/packages/core/src/blueprint-hi-contrast.scss
@@ -1,4 +1,4 @@
-/*!
+/*
 
 Copyright 2019-present Palantir Technologies, Inc. All rights reserved.
 Licensed under the Apache License, Version 2.0.

diff --git a/packages/core/src/blueprint.scss b/packages/core/src/blueprint.scss
@@ -1,4 +1,4 @@
-/*!
+/*
 
 Copyright 2015-present Palantir Technologies, Inc. All rights reserved.
 Licensed under the Apache License, Version 2.0.

diff --git a/packages/datetime/package.json b/packages/datetime/package.json
@@ -38,6 +38,7 @@
     "@blueprintjs/core": "^3.28.1",
     "classnames": "^2.2",
     "react-day-picker": "7.3.2",
+    "react-lifecycles-compat": "^3.0.4",
     "tslib": "~1.10.0"
   },
   "peerDependencies": {

diff --git a/packages/datetime/src/blueprint-datetime.scss b/packages/datetime/src/blueprint-datetime.scss
@@ -1,4 +1,4 @@
-/*!
+/*
 
 Copyright 2015-present Palantir Technologies, Inc. All rights reserved.
 Licensed under the Apache License, Version 2.0.

diff --git a/packages/datetime/src/dateInput.tsx b/packages/datetime/src/dateInput.tsx
@@ -117,6 +117,7 @@ export interface IDateInputProps extends IDatePickerBaseProps, IDateFormatProps,
      * Props to pass to the `Popover`.
      * Note that `content`, `autoFocus`, and `enforceFocus` cannot be changed.
      */
+    // eslint-disable-next-line @typescript-eslint/ban-types
     popoverProps?: Partial<IPopoverProps> & object;
 
     /**
@@ -265,8 +266,8 @@ export class DateInput extends AbstractPureComponent2<IDateInputProps, IDateInpu
         );
     }
 
-    public componentDidUpdate(prevProps: IDateInputProps, prevState: IDateInputState, snapshot?: {}) {
-        super.componentDidUpdate(prevProps, prevState, snapshot);
+    public componentDidUpdate(prevProps: IDateInputProps, prevState: IDateInputState) {
+        super.componentDidUpdate(prevProps, prevState);
         if (prevProps.value !== this.props.value) {
             this.setState({ value: this.props.value });
         }

diff --git a/packages/datetime/src/datePicker.tsx b/packages/datetime/src/datePicker.tsx
@@ -191,8 +191,8 @@ export class DatePicker extends AbstractPureComponent2<IDatePickerProps, IDatePi
         );
     }
 
-    public componentDidUpdate(prevProps: IDatePickerProps, prevState: IDatePickerState, snapshot?: {}) {
-        super.componentDidUpdate(prevProps, prevState, snapshot);
+    public componentDidUpdate(prevProps: IDatePickerProps, prevState: IDatePickerState) {
+        super.componentDidUpdate(prevProps, prevState);
         const { value } = this.props;
         if (value === prevProps.value) {
             // no action needed

diff --git a/packages/datetime/src/dateRangeInput.tsx b/packages/datetime/src/dateRangeInput.tsx
@@ -270,8 +270,8 @@ export class DateRangeInput extends AbstractPureComponent2<IDateRangeInputProps,
         };
     }
 
-    public componentDidUpdate(prevProps: IDateRangeInputProps, prevState: IDateRangeInputState, snapshot?: {}) {
-        super.componentDidUpdate(prevProps, prevState, snapshot);
+    public componentDidUpdate(prevProps: IDateRangeInputProps, prevState: IDateRangeInputState) {
+        super.componentDidUpdate(prevProps, prevState);
         const { isStartInputFocused, isEndInputFocused, shouldSelectAfterUpdate } = this.state;
 
         const startInputRef = getRef(this.startInputRef);

diff --git a/packages/datetime/src/dateRangePicker.tsx b/packages/datetime/src/dateRangePicker.tsx
@@ -249,8 +249,8 @@ export class DateRangePicker extends AbstractPureComponent2<IDateRangePickerProp
         );
     }
 
-    public componentDidUpdate(prevProps: IDateRangePickerProps, prevState: IDateRangePickerState, snapshot?: {}) {
-        super.componentDidUpdate(prevProps, prevState, snapshot);
+    public componentDidUpdate(prevProps: IDateRangePickerProps, prevState: IDateRangePickerState) {
+        super.componentDidUpdate(prevProps, prevState);
 
         if (
             !DateUtils.areRangesEqual(prevProps.value, this.props.value) ||

diff --git a/packages/datetime/test/dateInputTests.tsx b/packages/datetime/test/dateInputTests.tsx
@@ -20,8 +20,8 @@ import * as React from "react";
 import * as sinon from "sinon";
 
 import { Classes as CoreClasses, InputGroup, Intent, Keys, Popover, Position } from "@blueprintjs/core";
-import { Months } from "../src/common/months";
 import { Classes, DateInput, DatePicker, IDateInputProps, TimePicker, TimePrecision } from "../src";
+import { Months } from "../src/common/months";
 import { DATE_FORMAT } from "./common/dateFormat";
 import * as DateTestUtils from "./common/dateTestUtils";
 

diff --git a/packages/datetime/test/datePickerCaptionTests.tsx b/packages/datetime/test/datePickerCaptionTests.tsx
@@ -21,8 +21,8 @@ import * as sinon from "sinon";
 
 import { HTMLSelect } from "@blueprintjs/core";
 import { ClassNames } from "react-day-picker";
-import { DatePickerCaption, IDatePickerCaptionProps } from "../src/datePickerCaption";
 import { Classes, IDatePickerLocaleUtils } from "../src";
+import { DatePickerCaption, IDatePickerCaptionProps } from "../src/datePickerCaption";
 
 describe("<DatePickerCaption>", () => {
     const LOCALE_UTILS: IDatePickerLocaleUtils = {

diff --git a/packages/datetime/test/datePickerTests.tsx b/packages/datetime/test/datePickerTests.tsx
@@ -23,11 +23,11 @@ import * as sinon from "sinon";
 import { Button, Classes as CoreClasses, HTMLSelect, Menu, MenuItem } from "@blueprintjs/core";
 import { expectPropValidationError } from "@blueprintjs/test-commons";
 
+import { Classes, DatePicker, IDatePickerModifiers, IDatePickerProps, TimePicker, TimePrecision } from "../src";
 import * as DateUtils from "../src/common/dateUtils";
 import * as Errors from "../src/common/errors";
 import { Months } from "../src/common/months";
 import { IDatePickerState } from "../src/datePicker";
-import { Classes, DatePicker, IDatePickerModifiers, IDatePickerProps, TimePicker, TimePrecision } from "../src";
 import { IDatePickerShortcut, Shortcuts } from "../src/shortcuts";
 import { assertDatesEqual, assertDayDisabled, assertDayHidden } from "./common/dateTestUtils";
 

diff --git a/packages/datetime/test/dateRangeInputTests.tsx b/packages/datetime/test/dateRangeInputTests.tsx
@@ -2320,6 +2320,7 @@ describe("<DateRangeInput>", () => {
         });
 
         it("Clicking a start date causes focus to move to end field", () => {
+            // eslint-disable-next-line prefer-const
             let controlledRoot: WrappedComponentRoot;
 
             const onChange = (nextValue: DateRange) => controlledRoot.setProps({ value: nextValue });
@@ -2334,6 +2335,7 @@ describe("<DateRangeInput>", () => {
         });
 
         it("Typing in a field while hovering over a date shows the typed date, not the hovered date", () => {
+            // eslint-disable-next-line prefer-const
             let controlledRoot: WrappedComponentRoot;
 
             const onChange = (nextValue: DateRange) => controlledRoot.setProps({ value: nextValue });

diff --git a/packages/datetime/test/dateRangePickerTests.tsx b/packages/datetime/test/dateRangePickerTests.tsx
@@ -23,11 +23,6 @@ import * as sinon from "sinon";
 
 import { expectPropValidationError } from "@blueprintjs/test-commons";
 
-import * as DateUtils from "../src/common/dateUtils";
-import * as Errors from "../src/common/errors";
-import { Months } from "../src/common/months";
-import { DatePickerNavbar } from "../src/datePickerNavbar";
-import { IDateRangePickerState } from "../src/dateRangePicker";
 import {
     Classes as DateClasses,
     DateRange,
@@ -37,6 +32,11 @@ import {
     TimePicker,
     TimePrecision,
 } from "../src";
+import * as DateUtils from "../src/common/dateUtils";
+import * as Errors from "../src/common/errors";
+import { Months } from "../src/common/months";
+import { DatePickerNavbar } from "../src/datePickerNavbar";
+import { IDateRangePickerState } from "../src/dateRangePicker";
 import { IDateRangeShortcut, Shortcuts } from "../src/shortcuts";
 import { assertDayDisabled } from "./common/dateTestUtils";
 

diff --git a/packages/datetime/test/dateTimePickerTests.tsx b/packages/datetime/test/dateTimePickerTests.tsx
@@ -19,8 +19,8 @@ import { mount } from "enzyme";
 import * as React from "react";
 import * as sinon from "sinon";
 
-import { DateTimePicker } from "../src/dateTimePicker";
 import { Classes, DatePicker, TimePicker } from "../src";
+import { DateTimePicker } from "../src/dateTimePicker";
 
 describe("<DateTimePicker>", () => {
     it("renders a DatePicker and a TimePicker", () => {

diff --git a/packages/docs-app/package.json b/packages/docs-app/package.json
@@ -25,7 +25,7 @@
     "@blueprintjs/table": "^3.8.8",
     "@blueprintjs/test-commons": "^0.10.3",
     "@blueprintjs/timezone": "^3.6.6",
-    "@types/downloadjs": "^1.4.1",
+    "@documentalist/client": "~2.5.0",
     "chroma-js": "^2.1.0",
     "classnames": "^2.2",
     "dom4": "^2.1.5",
@@ -42,6 +42,7 @@
     "@blueprintjs/node-build-scripts": "^1.3.1",
     "@blueprintjs/webpack-build-scripts": "^1.0.0",
     "@types/chroma-js": "^1.4.1",
+    "@types/downloadjs": "^1.4.1",
     "copy-webpack-plugin": "^5.1.1",
     "npm-run-all": "^4.1.5",
     "webpack-cli": "^3.3.11",

diff --git a/packages/docs-app/src/components/colorPalettes.tsx b/packages/docs-app/src/components/colorPalettes.tsx
@@ -37,11 +37,11 @@ function getHexCode(color: string) {
 // @see http://stackoverflow.com/a/12043228/6342931
 function getLuminance(hex: string) {
     const rgb = parseInt(hex.substring(1), 16); // convert rrggbb to decimal
-    // eslint-disable  no-bitwise
+    /* eslint-disable no-bitwise */
     const red = (rgb >> 16) & 0xff;
     const green = (rgb >> 8) & 0xff;
     const blue = (rgb >> 0) & 0xff;
-    // eslint-enable
+    /* eslint-enable */
     const luma = 0.2126 * red + 0.7152 * green + 0.0722 * blue; // per ITU-R BT.709
     return luma;
 }

diff --git a/packages/docs-app/src/examples/core-examples/breadcrumbsExample.tsx b/packages/docs-app/src/examples/core-examples/breadcrumbsExample.tsx
@@ -14,6 +14,8 @@
  * limitations under the License.
  */
 
+/* eslint-disable max-classes-per-file */
+
 import * as React from "react";
 
 import {

diff --git a/packages/docs-app/src/examples/core-examples/contextMenuExample.tsx b/packages/docs-app/src/examples/core-examples/contextMenuExample.tsx
@@ -25,7 +25,7 @@ import { Example, IExampleProps } from "@blueprintjs/docs-theme";
 /**
  * This component uses the imperative ContextMenu API.
  */
-class GraphNode extends React.PureComponent<{}, { isContextMenuOpen: boolean }> {
+class GraphNode extends React.PureComponent<any, { isContextMenuOpen: boolean }> {
     public state = { isContextMenuOpen: false };
 
     public render() {

diff --git a/packages/docs-app/src/examples/core-examples/panelStackExample.tsx b/packages/docs-app/src/examples/core-examples/panelStackExample.tsx
@@ -14,6 +14,8 @@
  * limitations under the License.
  */
 
+/* eslint-disable max-classes-per-file */
+
 import * as React from "react";
 
 import { Button, H5, Intent, IPanel, IPanelProps, NumericInput, PanelStack, Switch, UL } from "@blueprintjs/core";

diff --git a/packages/docs-app/src/index.scss b/packages/docs-app/src/index.scss
@@ -1,4 +1,4 @@
-/*!
+/*
 
 Copyright 2015-present Palantir Technologies, Inc. All rights reserved.
 Licensed under the Apache License, Version 2.0.
@@ -27,7 +27,6 @@ Licensed under the Apache License, Version 2.0.
 @import "styles/resources";
 @import "styles/welcome";
 
-
 .docs-releases-menu .#{$ns}-menu {
   min-width: 270px;
 }

diff --git a/packages/docs-theme/src/docs-theme.scss b/packages/docs-theme/src/docs-theme.scss
@@ -1,4 +1,4 @@
-/*!
+/*
 
 Copyright 2015-present Palantir Technologies, Inc. All rights reserved.
 Licensed under the Apache License, Version 2.0.

diff --git a/packages/eslint-config/eslint-plugin-rules.json b/packages/eslint-config/eslint-plugin-rules.json
@@ -3,7 +3,10 @@
   "import/no-extraneous-dependencies": [
     "error",
     {
-      "devDependencies": false
+      "devDependencies": [
+        "**/test/**/*.{ts,tsx}",
+        "**/*.test.{ts,tsx}"
+      ]
     }
   ],
   "import/order": "off",

diff --git a/packages/eslint-plugin/package.json b/packages/eslint-plugin/package.json
@@ -20,6 +20,7 @@
   "devDependencies": {
     "@blueprintjs/node-build-scripts": "^1.3.1",
     "@types/dedent": "^0.7.0",
+    "dedent": "^0.7.0",
     "jest-junit": "^10.0.0"
   },
   "repository": {

diff --git a/packages/eslint-plugin/src/rules/__tests__/html-components.test.ts b/packages/eslint-plugin/src/rules/__tests__/html-components.test.ts
@@ -1,4 +1,4 @@
-/*!
+/*
  * Copyright 2019 Palantir Technologies, Inc. All rights reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");

diff --git a/packages/eslint-plugin/src/rules/__tests__/icon-components.test.ts b/packages/eslint-plugin/src/rules/__tests__/icon-components.test.ts
@@ -1,4 +1,4 @@
-/*!
+/*
  * Copyright 2019 Palantir Technologies, Inc. All rights reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");

diff --git a/packages/eslint-plugin/src/rules/index.ts b/packages/eslint-plugin/src/rules/index.ts
@@ -1,4 +1,4 @@
-/*!
+/*
  * Copyright 2019 Palantir Technologies, Inc. All rights reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
@@ -18,7 +18,7 @@ import { classesConstantsRule } from "./classes-constants";
 import { htmlComponentsRule } from "./html-components";
 import { iconComponentsRule } from "./icon-components";
 
-// eslint-disable-line import/no-default-export
+// eslint-disable-next-line import/no-default-export
 export default {
     "classes-constants": classesConstantsRule,
     "html-components": htmlComponentsRule,

diff --git a/packages/eslint-plugin/src/rules/utils/createRule.ts b/packages/eslint-plugin/src/rules/utils/createRule.ts
@@ -1,4 +1,4 @@
-/*!
+/*
  * Copyright 2019 Palantir Technologies, Inc. All rights reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");

diff --git a/packages/eslint-plugin/src/rules/utils/fixList.ts b/packages/eslint-plugin/src/rules/utils/fixList.ts
@@ -1,4 +1,4 @@
-/*!
+/*
  * Copyright 2019 Palantir Technologies, Inc. All rights reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");

diff --git a/packages/icons/src/blueprint-icons.scss b/packages/icons/src/blueprint-icons.scss
@@ -1,4 +1,4 @@
-/*!
+/*
 
 Copyright 2017-present Palantir Technologies, Inc. All rights reserved.
 Licensed under the Apache License, Version 2.0.

diff --git a/packages/landing-app/src/index.scss b/packages/landing-app/src/index.scss
@@ -1,4 +1,4 @@
-/*!
+/*
 
 Copyright 2015-present Palantir Technologies, Inc. All rights reserved.
 Licensed under the Apache License, Version 2.0.
@@ -129,8 +129,10 @@ footer {
     background-image: linear-gradient(
       90deg,
       rgba($white, 0) 0%,
-      rgba($white, 0.3) 50%,
-      rgba($white, 0) 100%
+      rgba($white, 0.3)
+      50%,
+      rgba($white, 0)
+      100%
     );
     content: "";
     display: block;

diff --git a/packages/select/src/blueprint-select.scss b/packages/select/src/blueprint-select.scss
@@ -1,4 +1,4 @@
-/*!
+/*
 
 Copyright 2017-present Palantir Technologies, Inc. All rights reserved.
 Licensed under the Apache License, Version 2.0.

diff --git a/packages/select/src/common/itemListRenderer.ts b/packages/select/src/common/itemListRenderer.ts
@@ -1,4 +1,4 @@
-/*!
+/*
  * Copyright 2017 Palantir Technologies, Inc. All rights reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");

diff --git a/packages/select/src/common/listItemsUtils.ts b/packages/select/src/common/listItemsUtils.ts
@@ -1,4 +1,4 @@
-/*!
+/*
  * Copyright 2018 Palantir Technologies, Inc. All rights reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");

diff --git a/packages/select/src/components/select/multiSelect.tsx b/packages/select/src/components/select/multiSelect.tsx
@@ -60,12 +60,14 @@ export interface IMultiSelectProps<T> extends IListItemsProps<T> {
     placeholder?: string;
 
     /** Props to spread to `Popover`. Note that `content` cannot be changed. */
+    // eslint-disable-next-line @typescript-eslint/ban-types
     popoverProps?: Partial<IPopoverProps> & object;
 
     /** Controlled selected values. */
     selectedItems?: T[];
 
     /** Props to spread to `TagInput`. Use `query` and `onQueryChange` to control the input. */
+    // eslint-disable-next-line @typescript-eslint/ban-types
     tagInputProps?: Partial<ITagInputProps> & object;
 
     /** Custom renderer to transform an item into tag content. */

diff --git a/packages/select/src/components/select/select.tsx b/packages/select/src/components/select/select.tsx
@@ -60,6 +60,7 @@ export interface ISelectProps<T> extends IListItemsProps<T> {
     inputProps?: IInputGroupProps & HTMLInputProps;
 
     /** Props to spread to `Popover`. Note that `content` cannot be changed. */
+    // eslint-disable-next-line @typescript-eslint/ban-types
     popoverProps?: Partial<IPopoverProps> & object;
 
     /**

diff --git a/packages/select/src/components/select/suggest.tsx b/packages/select/src/components/select/suggest.tsx
@@ -87,6 +87,7 @@ export interface ISuggestProps<T> extends IListItemsProps<T> {
     openOnKeyDown?: boolean;
 
     /** Props to spread to `Popover`. Note that `content` cannot be changed. */
+    // eslint-disable-next-line @typescript-eslint/ban-types
     popoverProps?: Partial<IPopoverProps> & object;
 
     /**

diff --git a/packages/select/test/suggestTests.tsx b/packages/select/test/suggestTests.tsx
@@ -21,8 +21,8 @@ import * as React from "react";
 import * as sinon from "sinon";
 
 import { IFilm, renderFilm, TOP_100_FILMS } from "../../docs-app/src/examples/select-examples/films";
-import { ISuggestProps, ISuggestState, Suggest } from "../src/components/select/suggest";
 import { IItemRendererProps, QueryList } from "../src";
+import { ISuggestProps, ISuggestState, Suggest } from "../src/components/select/suggest";
 import { selectComponentSuite } from "./selectComponentSuite";
 
 describe("Suggest", () => {

diff --git a/packages/table/src/quadrants/tableQuadrant.tsx b/packages/table/src/quadrants/tableQuadrant.tsx
@@ -130,7 +130,7 @@ export interface ITableQuadrantProps extends IProps {
 export class TableQuadrant extends AbstractComponent2<ITableQuadrantProps> {
     // we want the user to explicitly pass a quadrantType. define defaultProps as a Partial to avoid
     // declaring that and other required props here.
-    public static defaultProps: Partial<ITableQuadrantProps> & object = {
+    public static defaultProps: Partial<ITableQuadrantProps> = {
         enableRowHeader: true,
     };
-Original file line number
+Diff line change
@@ Expand Up / @@ -3,3 +3,4 @@ generated/ @@
     lib/
     dist/
     /site/
+    *.scss