Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] feat(NumericInput): supply input element to onValueChange #3982

Merged
merged 5 commits into from
Feb 26, 2020
Merged

[core] feat(NumericInput): supply input element to onValueChange #3982

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
744ebd4
[core] feat(NumericInput): supply input element in onValueChange call…
adidahiya Feb 26, 2020
682cc18
small refactor, use optional chaining to invoke callback
adidahiya Feb 26, 2020
a726ba1
fix lint
adidahiya Feb 26, 2020
e326c68
fix more tests
adidahiya Feb 26, 2020
03e78db
fix lint, remove describe.only
adidahiya Feb 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix lint, remove describe.only
  • Loading branch information
@adidahiya
adidahiya committed Feb 26, 2020
commit 03e78dbdb8ff6d64cfaedd41e217afda74a19334
6 changes: 3 additions & 3 deletions packages/core/test/controls/numericInputTests.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ describe("<NumericInput>", () => {
const component = mount(<NumericInput onValueChange={onValueChangeSpy} />);

const incrementButton = component.find(Button).first();
incrementButton.simulate("mousedown")
incrementButton.simulate("mousedown");
dispatchMouseEvent(document, "mouseup");

const inputElement = component
Expand All @@ -216,7 +216,7 @@ describe("<NumericInput>", () => {
const decrementButton = component.find(Button).last();

// incrementing from 0
incrementButton.simulate("mousedown")
incrementButton.simulate("mousedown");
dispatchMouseEvent(document, "mouseup");

expect(onButtonClickSpy.calledOnce).to.be.true;
Expand Down Expand Up @@ -507,7 +507,7 @@ describe("<NumericInput>", () => {
runInteractionSuite("Click '+'", "Click '-'", simulateIncrement, simulateDecrement);
});

describe.only("Value bounds", () => {
describe("Value bounds", () => {
describe("if no bounds are defined", () => {
it("enforces no minimum bound", () => {
const component = mount(<NumericInput />);
Expand Down