Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Button] fix loading spinner size #2666

Merged
merged 5 commits into from
Jul 10, 2018
Merged

[Button] fix loading spinner size #2666

merged 5 commits into from
Jul 10, 2018

Conversation

giladgray
Copy link
Contributor

@giladgray giladgray commented Jul 10, 2018 •
edited
Loading

Fixes #2663

  • oops.
  • add warning to Spinner for using size Classes

invliD
invliD approved these changes Jul 10, 2018
View reviewed changes
packages/docs-app/src/getting-started.md
@@ -146,7 +146,7 @@ npm install --save @types/moment-timezone
Blueprint's declaration files require **TypeScript 2.3+** for default generic parameter arguments: `<P = {}>`.

<div class="@ns-callout @ns-intent-primary @ns-icon-info-sign">
For more information, see [Understanding TypeScript](#blueprint/getting-started.understanding-typescript) below.
For more information, see [Understanding TypeScript](#blueprint/reading-the-docs.understanding-typescript).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related

packages/core/src/components/spinner/spinner.tsx Outdated
@@ -77,6 +79,15 @@ export class Spinner extends React.PureComponent<ISpinnerProps, {}> {
);
}

protected validateProps({ className = "" }: ISpinnerProps) {
if (className.indexOf(Classes.SMALL) >= 0) {
console.warn(SPINNER_WARN_CLASSES_SMALL);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we just add support for the classes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to #2667

@blueprint-bot
Copy link

fix link

Preview: documentation | landing | table

@blueprint-bot
Copy link

lint

Preview: documentation | landing | table

@blueprint-bot
Copy link

revert Spinner change

Preview: documentation | landing | table

@giladgray giladgray merged commit e2ec74a into develop Jul 10, 2018
@giladgray giladgray deleted the gg/spinner-button branch July 10, 2018 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@invliD invliD invliD approved these changes

@themadcreator themadcreator Awaiting requested review from themadcreator

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giladgray @blueprint-bot @invliD