Skip to content

Commit

Permalink
[v5] chore: minor docs tweaks
Browse files Browse the repository at this point in the history
  • Loading branch information
adidahiya committed Jun 22, 2023
1 parent 09aac36 commit b1fd55f
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ export class EditableText extends AbstractPureComponent<EditableTextProps, Edita

const hasModifierKey = altKey || ctrlKey || metaKey || shiftKey;
if (event.key === "Enter") {
// prevent IE11 from full screening with alt + enter
// prevent browsers (Edge?) from full screening with alt + enter
// shift + enter adds a newline by default
if (altKey || shiftKey) {
event.preventDefault();
Expand Down
9 changes: 0 additions & 9 deletions packages/core/src/components/spinner/spinner.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,6 @@ are provided as an enum: `SpinnerSize.SMALL`,
by including `Classes.SMALL` or `Classes.LARGE` in `className` instead of the
`size` prop (this prevents an API break when upgrading to 3.x).

<div class="@ns-callout @ns-intent-warning @ns-icon-warning-sign">
<h5 class="@ns-heading">IE11 compatibility note</h5>

IE11 [does not support CSS transitions on SVG elements][msdn-css-svg] so spinners with known
`value` will not smoothly transition as `value` changes. Indeterminate spinners still animate
correctly because they rely on CSS animations.

</div>

[msdn-css-svg]: https://developer.microsoft.com/en-us/microsoft-edge/platform/status/csstransitionsforsvgelements/?q=svg

@interface SpinnerProps
2 changes: 1 addition & 1 deletion packages/docs-app/src/getting-started.md
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ install typings for Blueprint's dependencies before you can consume it:
npm install --save @types/react @types/react-dom
```
Blueprint's declaration files require **TypeScript 3.8 or newer** for certain language features (like type-only imports/exports).
Blueprint's declaration files require **TypeScript 4.0 or newer** for certain language features (like type-only imports/exports).
We strive to be compatible with most TypeScript versions, but sometimes there are `lib.d.ts` changes which can create
compiler incompatibilities if you are using a `tsc` version different from the one used to build Blueprint (currently v4.1).
Expand Down

0 comments on commit b1fd55f

Please sign in to comment.