Skip to content

Commit

Permalink
manual lint fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
@adidahiya
adidahiya committed Jan 22, 2020
1 parent 6d2360b commit 36d0933
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 23 deletions.
4 changes: 2 additions & 2 deletions packages/core/src/common/utils.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,8 @@ export function countDecimalPlaces(num: number) {
if (!isFinite(num)) {
return 0;
}
let e = 1,
p = 0;
let e = 1;
let p = 0;
while (Math.round(num * e) / e !== num) {
e *= 10;
p++;
Expand Down
42 changes: 21 additions & 21 deletions packages/select/test/listItemsPropsTests.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,36 +21,36 @@ import { executeItemsEqual } from "../src/common/listItemsProps";
describe("IListItemsProps Utils", () => {
describe("executeItemsEqual", () => {
// interface for a non-primitive item value
interface ItemObject {
interface IItemObject {
id: string;
label: string;
listOfValues: number[];
nullField: null;
}

const ITEM_OBJECT_A: ItemObject = {
const ITEM_OBJECT_A: IItemObject = {
id: "A",
label: "Item A",
listOfValues: [1, 2],
nullField: null,
};

// Exactly the same contents as ITEM_OBJECT_A, but a different object
const ITEM_OBJECT_A_DUPLICATE: ItemObject = {
const ITEM_OBJECT_A_DUPLICATE: IItemObject = {
id: "A",
label: "Item A",
listOfValues: [1, 2],
nullField: null,
};

const ITEM_OBJECT_A_EQUIVALENT: ItemObject = {
const ITEM_OBJECT_A_EQUIVALENT: IItemObject = {
id: "A",
label: "Equivalent to item A based on 'id'",
listOfValues: [3, 4],
nullField: null,
};

const ITEM_OBJECT_B: ItemObject = {
const ITEM_OBJECT_B: IItemObject = {
id: "B",
label: "Item B",
listOfValues: [5, 6],
Expand Down Expand Up @@ -82,10 +82,10 @@ describe("IListItemsProps Utils", () => {

describe("itemsEqual is a property name", () => {
it("treats null and undefined as distinctly different", () => {
assert.isTrue(executeItemsEqual<ItemObject>("id", null, null));
assert.isTrue(executeItemsEqual<ItemObject>("id", undefined, undefined));
assert.isFalse(executeItemsEqual<ItemObject>("id", null, undefined));
assert.isFalse(executeItemsEqual<ItemObject>("id", undefined, null));
assert.isTrue(executeItemsEqual<IItemObject>("id", null, null));
assert.isTrue(executeItemsEqual<IItemObject>("id", undefined, undefined));
assert.isFalse(executeItemsEqual<IItemObject>("id", null, undefined));
assert.isFalse(executeItemsEqual<IItemObject>("id", undefined, null));
});

it("compares primitives correctly", () => {
Expand All @@ -101,13 +101,13 @@ describe("IListItemsProps Utils", () => {
});

it("does not incorrectly compare null to a property with a null value", () => {
assert.isFalse(executeItemsEqual<ItemObject>("nullField", ITEM_OBJECT_A, null));
assert.isFalse(executeItemsEqual<IItemObject>("nullField", ITEM_OBJECT_A, null));
});
});

describe("itemsEqual is a function", () => {
// Simple equality comparator that compares IDs of ItemObjects.
const equalityComparator = sinon.spy((itemA: ItemObject, itemB: ItemObject): boolean => {
const equalityComparator = sinon.spy((itemA: IItemObject, itemB: IItemObject): boolean => {
return itemA.id === itemB.id;
});

Expand All @@ -116,33 +116,33 @@ describe("IListItemsProps Utils", () => {
});

it("treats null and undefined as distinctly different", () => {
assert.isTrue(executeItemsEqual<ItemObject>(equalityComparator, null, null));
assert.isTrue(executeItemsEqual<ItemObject>(equalityComparator, undefined, undefined));
assert.isFalse(executeItemsEqual<ItemObject>(equalityComparator, null, undefined));
assert.isFalse(executeItemsEqual<ItemObject>(equalityComparator, undefined, null));
assert.isTrue(executeItemsEqual<IItemObject>(equalityComparator, null, null));
assert.isTrue(executeItemsEqual<IItemObject>(equalityComparator, undefined, undefined));
assert.isFalse(executeItemsEqual<IItemObject>(equalityComparator, null, undefined));
assert.isFalse(executeItemsEqual<IItemObject>(equalityComparator, undefined, null));

assert(!equalityComparator.called);
});

it("calls the function and uses its result (true)", () => {
assert.isTrue(
executeItemsEqual<ItemObject>(equalityComparator, ITEM_OBJECT_A, ITEM_OBJECT_A_EQUIVALENT),
executeItemsEqual<IItemObject>(equalityComparator, ITEM_OBJECT_A, ITEM_OBJECT_A_EQUIVALENT),
);
assert(equalityComparator.calledWith(ITEM_OBJECT_A, ITEM_OBJECT_A_EQUIVALENT));
assert(equalityComparator.returned(true));
});

it("calls the function and uses its result (false)", () => {
assert.isFalse(executeItemsEqual<ItemObject>(equalityComparator, ITEM_OBJECT_A, ITEM_OBJECT_B));
assert.isFalse(executeItemsEqual<IItemObject>(equalityComparator, ITEM_OBJECT_A, ITEM_OBJECT_B));
assert(equalityComparator.calledWith(ITEM_OBJECT_A, ITEM_OBJECT_B));
assert(equalityComparator.returned(false));
});

it("does not call the function if one param is null/undefined", () => {
assert.isFalse(executeItemsEqual<ItemObject>(equalityComparator, ITEM_OBJECT_A, null));
assert.isFalse(executeItemsEqual<ItemObject>(equalityComparator, ITEM_OBJECT_A, undefined));
assert.isFalse(executeItemsEqual<ItemObject>(equalityComparator, null, ITEM_OBJECT_A));
assert.isFalse(executeItemsEqual<ItemObject>(equalityComparator, undefined, ITEM_OBJECT_A));
assert.isFalse(executeItemsEqual<IItemObject>(equalityComparator, ITEM_OBJECT_A, null));
assert.isFalse(executeItemsEqual<IItemObject>(equalityComparator, ITEM_OBJECT_A, undefined));
assert.isFalse(executeItemsEqual<IItemObject>(equalityComparator, null, ITEM_OBJECT_A));
assert.isFalse(executeItemsEqual<IItemObject>(equalityComparator, undefined, ITEM_OBJECT_A));

assert(!equalityComparator.called);
});
Expand Down

0 comments on commit 36d0933

Please sign in to comment.