Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore when helper files are missing #11

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

BarDweller
Copy link
Contributor

Summary

The helper buildpack is designed to run when the extension runs, but is intended to be a no-op if run by mistake. This allows it to be present in other builders that may not even contain the extension. Today, this fails, because the helper buildpack expects all errors reading the files to be build errors.

Use Cases

A user includes the buildpack manually, or runs the builder image on a platform that does not support image extensions

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@BarDweller BarDweller requested a review from a team as a code owner April 15, 2024 15:10
@anthonydahanne anthonydahanne added type:bug A general bug semver:patch A change requiring a patch version bump labels Apr 15, 2024
@dmikusa
Copy link
Contributor

dmikusa commented Apr 15, 2024

Looks good to me, but you might want to add test coverage for these cases to prevent a possible regression in the future.

@dmikusa dmikusa merged commit e406633 into paketo-community:main Apr 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants