-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark BOM entry as Launch #111
Conversation
While Rust is not a launch dependency, it's version is important to know because it statically compiles binaries. Thus we are going to include its dependency into the launch BOM. This also works around an issue with buildpacks where the build BOM is not really visible. It's not included in `pack inspect` and the BOM label on the image. Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
I think that there is something in the works for |
@ForestEckhardt - Yes, I think you're referring to buildpacks/libcnb#77. I do see this as a workaround, but I think you could also make a case that it should be included in the Launch layer. Rust is like Go in that it statically compiles things into the produced binaries. That means you need to know what tools did the compiling to know if your binaries are impacted by a CVE or bug. It's a little more pronounced in Go because Go compiles in a standard library, but the issue is the same with Rust or any other language tool set that makes use of static compilation. I did look at the paketo-buildpacks/go-dist buildpack and it is, as far as I can tell, setting build and launch on its Go BOM entry. |
That is only true for the unit test during actual operation in a standard buildpack configuration the Go dependency only goes into the Build BOM. As for the exposure of the Build BOM I am referencing this issue here buildpacks/pack#1221 |
Lol, that is the issue I meant to link to but copy and paste is hard. Sorry.
OK, that's good to know. I guess then we should label this as a temporary workaround. I can adjust the comment to indicate it should be removed when the pack issue is resolved. |
That totally works for me! |
Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
Comment updated. |
While Rust is not a launch dependency, it's version is important to know because it statically compiles binaries. Thus we are going to include its dependency into the launch BOM. This also works around an issue with buildpacks where the build BOM is not really visible. It's not included in
pack inspect
and the BOM label on the image.Resolves #26