Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use yarn layer as target for SBoM generation #241

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Use yarn layer as target for SBoM generation #241

merged 1 commit into from
Jul 14, 2022

Conversation

thitch97
Copy link
Contributor

@thitch97 thitch97 commented Jul 14, 2022 •
edited
Loading

Summary

GenerateFromDependency() should receive the path to the yarn layer instead of /workspace just as in other dependency buildpacks (cpython, node-engine).

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@thitch97 thitch97 requested a review from a team as a code owner July 14, 2022 15:27
@TisVictress TisVictress added the semver:minor A change requiring a minor version bump label Jul 14, 2022
@TisVictress TisVictress merged commit 317d721 into main Jul 14, 2022
@TisVictress TisVictress deleted the sbom-target branch July 14, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TisVictress TisVictress TisVictress approved these changes

@paketo-bot-reviewer paketo-bot-reviewer Awaiting requested review from paketo-bot-reviewer paketo-bot-reviewer is a code owner automatically assigned from paketo-buildpacks/nodejs-maintainers

Assignees
No one assigned
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thitch97 @TisVictress