Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy Up #235

Merged
merged 8 commits into from
Jun 21, 2022
Merged

Tidy Up #235

merged 8 commits into from
Jun 21, 2022

Conversation

joshuatcasey
Copy link
Contributor

  • Add .idea/ and .DS_Store to .gitignore
  • Rerun go generate
  • Bump Golang to 1.17
  • Bump Golang to 1.18
  • Add variables to simplify build_test
  • Use expectations and sequential tests when dealing with Env vars
  • Use draft.Planner from packit directly
  • Clarify readme

@joshuatcasey joshuatcasey requested a review from a team as a code owner June 21, 2022 21:28
@ryanmoran ryanmoran added the semver:patch A change requiring a patch version bump label Jun 21, 2022
@ryanmoran ryanmoran merged commit 53c13ae into paketo-buildpacks:main Jun 21, 2022
@joshuatcasey joshuatcasey deleted the jtc/tidy-up-for-no-deps branch June 23, 2022 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanmoran ryanmoran ryanmoran approved these changes

@thitch97 thitch97 Awaiting requested review from thitch97 thitch97 is a code owner automatically assigned from paketo-buildpacks/nodejs-maintainers

@TisVictress TisVictress Awaiting requested review from TisVictress TisVictress is a code owner automatically assigned from paketo-buildpacks/nodejs-maintainers

Assignees
No one assigned
Labels
semver:patch A change requiring a patch version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshuatcasey @ryanmoran