Enable setting two dependency ids #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the update package dependency workflow, a dependency id is required. This is used to update both the buildpack.toml and package.toml. However, the id is not always the same in both files. By default, the workflow will use the DEPENDENCY variable for both. You can however also set one of BP_DEPENDENCY or PKG_DEPENDENCY. Do not set both! You need to set DEPENDENCY and this is where the workflow will obtain the new version (it looks at the image referenced by the id, like gcr.io/paketo-buildpacks/bellsoft-liberica). You can then set the variable for the value which differs from DEPENDENCY. Typically, this will be BP_DEPENDENCY as the package.toml file uses the full image name in it where buildpack.toml has the buildpack id name. Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
This was referenced Oct 7, 2021
This was referenced Oct 7, 2021
This was referenced Oct 8, 2021
This was referenced Oct 8, 2021
This was referenced Oct 17, 2021
This was referenced Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
During the update package dependency workflow, a dependency id is required. This is used to update both the buildpack.toml and package.toml. However, the id is not always the same in both files. By default, the workflow will use the DEPENDENCY variable for both. You can however also set one of BP_DEPENDENCY or PKG_DEPENDENCY. Do not set both! You need to set DEPENDENCY and this is where the workflow will obtain the new version (it looks at the image referenced by the id, like gcr.io/paketo-buildpacks/bellsoft-liberica). You can then set the variable for the value which differs from DEPENDENCY. Typically, this will be BP_DEPENDENCY as the package.toml file uses the full image name in it where buildpack.toml has the buildpack id name.
Use Cases
Checklist