Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always set TTL_SH_PUBLISH #1610

Closed
wants to merge 2 commits into from
Closed

Always set TTL_SH_PUBLISH #1610

wants to merge 2 commits into from

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented May 15, 2024

Summary

This fixes an error where it tries to access this env and it's not set, which is an error cause of our strict script settings. I don't think the error was hurting anything, but this cleans it up.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

This fixes an error where it tries to access this env and it's not set, which is an error cause our strict script settings

Signed-off-by: Daniel Mikusa <dan@mikusa.com>
@dmikusa dmikusa added type:bug A general bug semver:patch A change requiring a patch version bump labels May 15, 2024
@dmikusa dmikusa requested a review from a team as a code owner May 15, 2024 02:20
Signed-off-by: Daniel Mikusa <dan@mikusa.com>
@dmikusa dmikusa closed this May 15, 2024
@dmikusa dmikusa deleted the ttlsh-fix branch May 15, 2024 03:08
@dmikusa dmikusa restored the ttlsh-fix branch May 15, 2024 03:08
@anthonydahanne anthonydahanne deleted the ttlsh-fix branch May 17, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant