Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for merge queues #1036

Closed
dmikusa opened this issue Mar 7, 2023 · 0 comments · Fixed by #1061
Closed

Add support for merge queues #1036

dmikusa opened this issue Mar 7, 2023 · 0 comments · Fixed by #1061
Labels
hacktoberfest Hacktoberfest eligible note:good-first-issue A good first issue to get started with note:ideal-for-contribution An issue that a contributor can help us with type:enhancement A general enhancement

Comments

@dmikusa
Copy link
Contributor

dmikusa commented Mar 7, 2023

Describe the Enhancement

Github Actions has beta support for merge queues. To enable merge queues, you need to add a trigger for merge_group: to the workflows that should run when the PR is added to the merge queue. This trigger needs to be added to pipeline-builder.

Possible Solution

Add the trigger and ensure that it can easily be added to workflows generated by pipeline-builder.

Motivation

Support for Merge Queues.
@dmikusa dmikusa added type:enhancement A general enhancement note:good-first-issue A good first issue to get started with note:ideal-for-contribution An issue that a contributor can help us with labels Mar 7, 2023
dmikusa added a commit that referenced this issue Mar 18, 2023
@dmikusa
Add support for merge queues
be36066 
This PR adds a merge group event type which can be added to workflows as a trigger. It exposes the documented types, of which there is only one, and it adds filters for branch and path (these are not documented, but I see references to them in other projects and they are needed to make this useful). It also updates the tests workflow so that tests are run when a merge group event is detected. It does not add label checks or action workflows. Those will run on PR, which is probably sufficient. We just want to re-run the tests in the merge queue to validate.

This PR has not been tested because we cannot use the merge queue feature yet. EasyCLA is not compatible. This is an attempt to prepare but a follow up PR may be required. Consider this experimental for now.

Resolves #1036

Signed-off-by: Daniel Mikusa <dan@mikusa.com>
@dmikusa dmikusa mentioned this issue Mar 18, 2023
Merged
@anthonydahanne anthonydahanne added the hacktoberfest Hacktoberfest eligible label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest Hacktoberfest eligible note:good-first-issue A good first issue to get started with note:ideal-for-contribution An issue that a contributor can help us with type:enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for merge queues paketo-buildpacks/pipeline-builder
2 participants
@anthonydahanne @dmikusa