Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helper Helpers #31

Merged
merged 4 commits into from
Sep 20, 2021
Merged

Helper Helpers #31

merged 4 commits into from
Sep 20, 2021

Conversation

nebhale
Copy link
Member

@nebhale nebhale commented Nov 13, 2020

This change adds some more helper functions to sherpa that are particularly useful in the environment that exec.d's run in.

@nebhale
Helper Helpers
f6770eb 
This change adds some more helper functions to sherpa that are particularly
useful in the environment that exec.d's run in.

Signed-off-by: Ben Hale <bhale@vmware.com>
@nebhale nebhale added semver:minor A change requiring a minor version bump type:enhancement A general enhancement labels Nov 13, 2020
@nebhale nebhale requested a review from ekcasey November 13, 2020 19:04
ekcasey
ekcasey reviewed Nov 13, 2020
View reviewed changes
ekcasey
ekcasey reviewed Nov 13, 2020
View reviewed changes
@nebhale @ekcasey
Update sherpa/env_var.go
3a7e6f4 
Signed-off-by: Ben Hale <bhale@vmware.com>

Co-authored-by: Emily Casey <ecasey@vmware.com>
@nebhale nebhale requested a review from ekcasey November 13, 2020 21:36
@nebhale
Copy link
Member Author

nebhale commented Nov 16, 2020

@ekcasey I’m going to leave this in draft until we’ve got a proto-typical implementation of your preferred binding-related buildpack design. Just in case we need to add or remove anything else.

@nebhale
Remove Unnecessary Function
41d5305 
Since and is the default behavior when multiple predicates are passed, this
function while descriptive is redundant.

Signed-off-by: Ben Hale <bhale@vmware.com>
@linux-foundation-easycla
Copy link

CLA Not Signed

  • Ben Hale (f6770eb ,3a7e6f4f55e5820183735ecc89d48a6905718226 ,41d5305ca03f323efb8dea5189749282a8176f8c) is authorized, but they must confirm their affiliation with their company. Start the authorization process by clicking here, click "Corporate",select the appropriate company from the list, then confirm your affiliation on the page that appears. For further assistance with EasyCLA, please submit a support request ticket.

@dmikusa dmikusa marked this pull request as ready for review September 20, 2021 20:58
@dmikusa dmikusa requested a review from a team September 20, 2021 20:58
@dmikusa dmikusa merged commit 2aada22 into main Sep 20, 2021
@dmikusa dmikusa deleted the helper-helpers branch September 20, 2021 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekcasey ekcasey ekcasey approved these changes

@dmikusa dmikusa dmikusa approved these changes

Assignees
No one assigned
Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nebhale @ekcasey @dmikusa