Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM64 binaries #123

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Add ARM64 binaries #123

merged 1 commit into from
Jan 23, 2024

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented Jan 21, 2024

Summary

This PR adds ARM64 binaries & updates pipeline descriptor & workflows. It also updates the buildpack to download the tar gzip'd binaries. The unzipped binary is amd64 only, so to make it work with both amd64 and arm64 the easiest option is to download the archives instead.

Use Cases

Multi-arch support.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@dmikusa dmikusa added semver:minor A change requiring a minor version bump type:dependency-upgrade A dependency upgrade labels Jan 21, 2024
@dmikusa dmikusa requested a review from a team as a code owner January 21, 2024 00:42
@anthonydahanne
Copy link
Member

please rebase on latest main

This PR adds ARM64 binaries & updates pipeline descriptor & workflows. It also updates the buildpack to download the tar gzip'd binaries. The unzipped binary is amd64 only, so to make it work with both amd64 and arm64 the easiest option is to download the archives instead.

Signed-off-by: Daniel Mikusa <dan@mikusa.com>
@dmikusa
Copy link
Contributor Author

dmikusa commented Jan 22, 2024

Rebased.

@anthonydahanne anthonydahanne merged commit c36e733 into main Jan 23, 2024
5 checks passed
@anthonydahanne anthonydahanne deleted the arm64 branch January 23, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump type:dependency-upgrade A dependency upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants