Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings.gradle[.kts] to files to detect #59

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

stigkj
Copy link
Contributor

@stigkj stigkj commented Mar 16, 2021

Summary

Add settings.gradle[.kts] to files to detect if it is a Gradle project.

Use Cases

In a multi-module project it is possible to change the names of all the build files. This is for example used to make it easier to jump to the correct file in an editor, i.e. instead of having many build.gradle.kts files, you can have a unique name for each based on the module name.

These names will be configured in a settings.gradle[.kts] file in the root of the project, so to support Gradle projects doing this just add these files to the list of files used for detecting a Gradle project.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.

In a multi-module project it is possible to change the names of all
the build files. This is for example used to make it easier to jump
to the correct file in an editor, i.e. instead of having many
`build.gradle.kts` files, you can have a unique name for each based
on the module name.

These names will be configured in a `settings.gradle[.kts]` file in
the root of the project, so to support Gradle projects doing this
just add these files to the list of files used for detecting a Gradle
project.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 16, 2021

CLA Signed

The committers are authorized under a signed CLA.

  • ✅ Stig Kleppe-Jørgensen (150d563)

@stigkj stigkj marked this pull request as ready for review March 16, 2021 11:39
@stigkj stigkj requested a review from a team March 16, 2021 11:39
Copy link
Member

@ekcasey ekcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look great! Thanks for the contribution.

@ekcasey ekcasey added semver:minor A change requiring a minor version bump type:enhancement A general enhancement labels Mar 17, 2021
@ekcasey ekcasey merged commit b16357a into paketo-buildpacks:main Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants