Preview: point release v23.1.0

.github/workflows/bsd.yml

@@ -0,0 +1,67 @@
+name: bsd
+on:
+  push:
+    branches:
+      - master
+    paths:
+      - '*.py'
+      - 'tox.ini'
+      - '.github/workflows/bsd.yml'
+  pull_request:
+    branches:
+      - master
+permissions:
+  # BOLD WARNING: do not add permissions, this workflow executes remote code
+  contents: read
+env:
+  FORCE_COLOR: 1
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+jobs:
+  freebsd:
+    name: freebsd
+    timeout-minutes: 20
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: true
+    steps:
+      - uses: actions/checkout@v4
+      - uses: vmactions/freebsd-vm@v1
+        with:
+          prepare: pkg install -y nginx python311 py311-pip py311-tox py311-sqlite3
+          usesh: true
+          copyback: false
+          # not a typo: "openssl --version" != "openssl version"
+          run: |
+            uname -a \
+            && python3.11 --version \
+            && python3.11 -m tox --version \
+            && openssl version \
+            && pkg info nginx \
+            && python3.11 -m tox -e run-module \
+            && python3.11 -m tox -e run-entrypoint \
+            && python3.11 -m tox -e py
+
+  openbsd:
+    name: openbsd
+    timeout-minutes: 20
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: true
+    steps:
+      - uses: actions/checkout@v4
+      - uses: vmactions/openbsd-vm@v1
+        with:
+          prepare: pkg_add python py3-pip py3-tox py3-sqlite3 nginx
+          usesh: true
+          copyback: false
+          run: |
+            uname -a \
+            && python3 --version \
+            && python3 -m tox --version \
+            && openssl version \
+            && pkg_info nginx \
+            && python3 -m tox -e run-module \
+            && python3 -m tox -e run-entrypoint \
+            && python3 -m tox -e py

.github/workflows/illumos.yml

@@ -0,0 +1,52 @@
+name: illumos
+on:
+  push:
+    branches:
+      - master
+    paths:
+      - '*.py'
+      - 'tox.ini'
+      - '.github/workflows/illumos.yml'
+  pull_request:
+    branches:
+      - master
+permissions:
+  # BOLD WARNING: do not add permissions, this workflow executes remote code
+  contents: read
+env:
+  FORCE_COLOR: 1
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+jobs:
+  omnios:
+    name: illumos
+    timeout-minutes: 20
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: true
+    steps:
+      - uses: actions/checkout@v4
+      - uses: vmactions/omnios-vm@v1
+        with:
+          # need gcc: compile greenlet from source
+          # autoconf must pretend inotify unavail: libev FTBFS
+          # /tmp/.nginx must exist because nginx will not create configured tmp
+          prepare: |
+            pkg install pip-311 python-311 sqlite-3 nginx gcc13
+          usesh: true
+          copyback: false
+          run: |
+            cat /etc/release \
+            && uname -a \
+            && python3 --version \
+            && openssl version \
+            && pkg info nginx \
+            && gcc -dM -E - </dev/null \
+            && ac_cv_header_sys_inotify_h=no ac_cv_func_inotify_init=no python3 -m pip install gevent \
+            && mkdir -p /tmp/.nginx \
+            && python3 -m pip install tox \
+            && python3 -m tox --version \
+            && python3 -m tox -e run-module \
+            && python3 -m tox -e run-entrypoint \
+            && python3 -m tox -e py

.github/workflows/tox.yml

@@ -1,5 +1,11 @@
 name: tox
-on: [push, pull_request]
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
 permissions:
   contents: read # to fetch code (actions/checkout)
 env:
@@ -19,7 +25,7 @@ jobs:
          - ubuntu-latest
          # not defaulting to macos-latest: Python <= 3.9 was missing from macos-14 @ arm64
          - macos-13
-         # Not testing Windows, because tests need Unix-only fcntl, grp, pwd, etc.
+         # Not testing Windows, because tests need Unix-only non-blocking pipes, grp, pwd, etc.
         python-version:
          # CPython <= 3.7 is EoL since 2023-06-27
          - "3.7"
@@ -54,6 +60,11 @@ jobs:
           cache-dependency-path: requirements_test.txt
           check-latest: true
           allow-prereleases: ${{ matrix.unsupported }}
+      - name: Add test utils
+        if: matrix.os == 'ubuntu-latest'
+        run: |
+          sudo systemctl mask nginx.service
+          sudo apt install nginx openssl
       - name: Install Dependencies
         run: |
           python -m pip install --upgrade pip

.pylintrc

@@ -17,7 +17,7 @@ disable=
     broad-except,
     duplicate-bases,
     duplicate-code,
-    eval-used,
+    superfluous-parens,
     fixme,
     import-error,
     import-outside-toplevel,

appveyor.yml

@@ -13,7 +13,7 @@ environment:
     #- TOXENV: run-entrypoint
     #  PYTHON: "C:\\Python38-x64"
     # Windows is not ready for testing!!!
-    # Python's fcntl, grp, pwd, os.geteuid(), and socket.AF_UNIX are all Unix-only.
+    # Python's non-blocking pipes, grp, pwd, os.geteuid(), and socket.AF_UNIX are all Unix-only.
     #- TOXENV: py35
     #  PYTHON: "C:\\Python35-x64"
     #- TOXENV: py36

docs/source/2024-news.rst

@@ -2,6 +2,11 @@
 Changelog - 2024
 ================
 
+23.1.0 - 2TBDTBDTBD
+===================
+
+- source distribution (sdist) now includes tox.ini to simplify downstream packaging (:pr:`3269`)
+
 23.0.0 - 2024-08-10
 ===================
 
@@ -24,10 +29,10 @@ Changelog - 2024
 
 ** Breaking changes **
 
-- refuse requests where the uri field is empty (:pr:`3255`)
-- refuse requests with invalid CR/LR/NUL in heade field values (:pr:`3253`)
+- refuse invalid requests where the uri field is empty (:pr:`3255`)
+- refuse invalid requests with CR/LR/NUL in header field values (:pr:`3253`)
 - remove temporary ``--tolerate-dangerous-framing`` switch from 22.0 (:pr:`3260`)
-- If any of the breaking changes affect you, be aware that now refused requests can post a security problem, especially so in setups involving request pipe-lining and/or proxies.
+- If any of these affect you, be aware that now refused requests can pose a security problem, especially so in setups involving request pipe-lining and/or proxies.
 
 22.0.0 - 2024-04-17
 ===================

docs/source/faq.rst

@@ -109,6 +109,15 @@ threads. However `a work has been started
 .. _worker_class: settings.html#worker-class
 .. _`number of workers`: design.html#how-many-workers
 
+Why are are responses delayed on startup/re-exec?
+-------------------------------------------------
+
+If workers are competing for resources during wsgi import, the result may be slower
+than sequential startup. Either avoid duplicate work altogether
+via :ref:`preload-app`. Or, if that is not an option, tune worker spawn sequence by
+adding a delay in the :ref:`pre-fork` to sacrifice overall startup completion time
+for reduced time for first request completion.
+
 Why I don't see any logs in the console?
 ----------------------------------------
 

docs/source/settings.rst

@@ -82,6 +82,10 @@ The default behavior is to attempt inotify with a fallback to file
 system polling. Generally, inotify should be preferred if available
 because it consumes less system resources.
 
+.. note::
+   If the application fails to load while this option is used,
+   the (potentially sensitive!) traceback will be shared in
+   the response to subsequent HTTP requests.
 .. note::
    In order to use the inotify reloader, you must have the ``inotify``
    package installed.
@@ -114,10 +118,13 @@ Valid engines are:
 
 **Default:** ``[]``
 
-Extends :ref:`reload` option to also watch and reload on additional files
+Alternative or extension to :ref:`reload` option to (also) watch
+and reload on additional files
 (e.g., templates, configurations, specifications, etc.).
 
 .. versionadded:: 19.8
+.. versionchanged:: 23.FIXME
+    Option no longer silently ignored if used without :ref:`reload`.
 
 .. _spew:
 
@@ -461,6 +468,19 @@ if not provided).
 
 .. versionadded:: 19.2
 
+.. _enable-backlog-metric:
+
+``enable_backlog_metric``
+~~~~~~~~~~~~~~~~~~~~~~~~~
+
+**Command line:** ``--enable-backlog-metric``
+
+**Default:** ``False``
+
+Enable socket backlog metric (only supported on Linux).
+
+.. versionadded:: 23.1
+
 Process Naming
 --------------
 
@@ -1100,6 +1120,10 @@ A filename to use for the PID file.
 
 If not set, no PID file will be written.
 
+.. note::
+   During master re-exec, a ``.2`` suffix is added to
+   this path to store the PID of the newly launched master.
+
 .. _worker-tmp-dir:
 
 ``worker_tmp_dir``

gunicorn/__init__.py

@@ -2,7 +2,7 @@
 # This file is part of gunicorn released under the MIT license.
 # See the NOTICE for more information.
 
-version_info = (23, 0, 0)
-__version__ = ".".join([str(v) for v in version_info])
+version_info = (23, 1, 0)
+__version__ = ".".join([str(v) for v in version_info]) + "a1"
 SERVER = "gunicorn"
 SERVER_SOFTWARE = "%s/%s" % (SERVER, __version__)