Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unhelpful log message with wrong MSVS version #148

Merged
merged 1 commit into from
Apr 6, 2019
Merged

fix unhelpful log message with wrong MSVS version #148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions install.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ function errorSetMSVSVersion() {
}

function errorInvalidMSVSVersion() {
console.log('Invalid msvs_version ' + msvsVersion + '\n');
console.log('Invalid msvs_version ' + process.env.npm_config_msvs_version + '\n');
console.log('Please set your Microsoft Visual Studio version before you run npm install');
console.log('Example for Visual Studio 2015:\n');
console.log(' For you user only:\n');
Expand Down Expand Up @@ -371,4 +371,4 @@ if (os.platform() !== 'win32') {
});
});
}
}
}