Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VL-274 Change pattern match docIdx field #132

Merged
merged 2 commits into from
Jun 19, 2023
Merged

VL-274 Change pattern match docIdx field #132

merged 2 commits into from
Jun 19, 2023

Conversation

datalek
Copy link
Contributor

@datalek datalek commented Jun 19, 2023

Motivation and Context

The generator used to generate models has a bug on string pattern definition. This PR fix the validation on docIdx parameter.

How Has This Been Tested?

Local test

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@datalek datalek requested a review from kin0992 as a code owner June 19, 2023 08:22
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

kin0992
kin0992 approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@kin0992 kin0992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍏

@datalek datalek merged commit 89c313f into main Jun 19, 2023
@datalek datalek deleted the hotfixes/pattern-match-docidx branch June 19, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kin0992 kin0992 kin0992 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@datalek @kin0992