[PIN-2303] Refactor release fixes #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
@mui/icons-materialbundler bug. Where the bundler itself doesn't recognize and transpile correctly the type of import of certain icons.The fix (acc78fa) tells directly to the bundler that the library uses the cjs default export, setting the commonjs plugin's property
defaultIsModuleExportstofalse.This PR also removes all the
React.lazycalls because currently Vite does not offer a way to inject thenoncetoken to the dynamic bundle's generated script tags. Looking forward for a future Vite implementation on this related issue.Also, in this PR:
vite previewmode.