fix: Improved memory usage #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ved file byte array read
…re-read before saving it to blob storage
| BlobStorageResponse blobStorageResponse; | ||
|
|
||
| ReceiptBlobClientImpl blobClient = ReceiptBlobClientImpl.getInstance(); | ||
|
|
||
| //Save to Blob Storage | ||
| try { | ||
| blobStorageResponse = blobClient.savePdfToBlobStorage(pdfEngineResponse.getPdf(), pdfFileName); | ||
| File tempPdf = new File(TEMP_FILE_PATH); |
There was a problem hiding this comment.
Does it work well with concurrency ?
…cted folder) and deletion
… - improved exceptions logging
…n on temp directory existence
|
This pull request does not contain a valid label. Please add one of the following labels: |
|
Comment this PR with update_code to update |
|
SonarCloud Quality Gate failed.
|
alessio-cialini
pushed a commit
that referenced
this pull request
Oct 17, 2023
* [fix-improve-memory-usage] Managed the closure of input streams that remained open * [fix-improve-memory-usage] Sending zip template as InputStream - removed file byte array read * [fix-improve-memory-usage] Pdf-engine response saved to pdf file and re-read before saving it to blob storage * [fix-improve-memory-usage] Used temporary files with unique names for storing PDFs * [fix-improve-memory-usage] Manual delete of temp file * [fix-improve-memory-usage] To be deleted file to commit temp folder * [fix-improve-memory-usage] Deleted test pdf file * [fix-improve-memory-usage] Improved temp files generation (with protected folder) and deletion * [fix-improve-memory-usage] Improved test coverage and testing with temp files * [fix-improve-memory-usage] Deleted file used to commit temp folder * [fix-improve-memory-usage] Added temp directory creation and deletion - improved exceptions logging * [fix-improve-memory-usage] Extracted save temp file method - condition on temp directory existence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Motivation and Context
Fix memory problems
Types of changes