Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRDP-17] Reach unit tests coverage #14

Merged
merged 5 commits into from
Jun 22, 2023
Merged

[PRDP-17] Reach unit tests coverage #14

merged 5 commits into from
Jun 22, 2023

Conversation

svariant
Copy link
Collaborator

@svariant svariant commented Jun 21, 2023 •
edited
Loading

List of Changes

  • Added unit tests for classes' constructors and instances
  • Fixed function-queue loop in case of invalid BizEvent message:
    • Throws error custom in case of invalid message structure
    • Added unit test

Motivation and Context

Reach 80% test coverage

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@svariant svariant requested a review from pasqualespica June 21, 2023 09:19
@svariant svariant added the enhancement New feature or request label Jun 21, 2023
@github-actions
Copy link

This pull request does not contain a valid label. Please add one of the following labels: [patch, minor, major, skip]

@github-actions
Copy link

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

60.0% 60.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

pasqualespica
pasqualespica approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great 🤖

@pasqualespica pasqualespica merged commit 69e8f83 into main Jun 22, 2023
gioelemella pushed a commit that referenced this pull request Jun 27, 2023
@svariant
[PRDP-17] Reach unit tests coverage (#14)
e02f4ec 
* [PRDP-17] Added unit tests for singleton instances and class constructors

* [PRDP-17] Fix error event data null and discarder info

* [PRDP-17] Fix function loop in case of wrong biz event structure

* [PRDP-17] Throw error in case of invalid biz event message - added unit test

* [PRDP-17] Throw receipt not found exception
alessio-cialini pushed a commit that referenced this pull request Oct 17, 2023
@svariant
[PRDP-17] Reach unit tests coverage (#14)
1696e87 
* [PRDP-17] Added unit tests for singleton instances and class constructors

* [PRDP-17] Fix error event data null and discarder info

* [PRDP-17] Fix function loop in case of wrong biz event structure

* [PRDP-17] Throw error in case of invalid biz event message - added unit test

* [PRDP-17] Throw receipt not found exception
@alessio-cialini alessio-cialini deleted the PRDP-17-reach-test-coverage branch November 16, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqualespica pasqualespica pasqualespica approved these changes

Assignees

@svariant svariant

Labels
enhancement New feature or request size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svariant @pasqualespica