Merge pull request #79 from pagopa/fix

Fix GetPayment XML validation error

helm/Chart.yaml

@@ -2,8 +2,8 @@ apiVersion: v2
 name: pagopa-gpd-payments
 description: Microservice that exposes API for payment receipts retrieving and other operations
 type: application
-version: 0.48.0
-appVersion: 0.12.0
+version: 0.49.0
+appVersion: 0.12.0-1-fix
 dependencies:
   - name: microservice-chart
     version: 2.4.0

helm/values-dev.yaml

@@ -4,7 +4,7 @@ microservice-chart:
   fullnameOverride: ""
   image:
     repository: ghcr.io/pagopa/pagopa-gpd-payments
-    tag: "0.12.0"
+    tag: "0.12.0-1-fix"
     pullPolicy: Always
   livenessProbe:
     httpGet:

helm/values-prod.yaml

@@ -4,7 +4,7 @@ microservice-chart:
   fullnameOverride: ""
   image:
     repository: ghcr.io/pagopa/pagopa-gpd-payments
-    tag: "0.12.0"
+    tag: "0.12.0-1-fix"
     pullPolicy: Always
   livenessProbe:
     httpGet:

helm/values-uat.yaml

@@ -4,7 +4,7 @@ microservice-chart:
   fullnameOverride: ""
   image:
     repository: ghcr.io/pagopa/pagopa-gpd-payments
-    tag: "0.12.0"
+    tag: "0.12.0-1-fix"
     pullPolicy: Always
   livenessProbe:
     httpGet:

openapi/openapi.json

@@ -4,7 +4,7 @@
     "title": "PagoPA API Payments",
     "description": "Payments",
     "termsOfService": "https://www.pagopa.gov.it/",
-    "version": "0.12.0"
+    "version": "0.12.0-1-fix"
   },
   "servers": [
     {

pom.xml

@@ -13,7 +13,7 @@
 
     <groupId>it.gov.pagopa</groupId>
     <artifactId>payments</artifactId>
-    <version>0.12.0</version>
+    <version>0.12.0-1-fix</version>
     <name>Payments</name>
     <description>Payments</description>
 

src/main/java/it/gov/pagopa/payments/service/PartnerService.java

@@ -362,7 +362,6 @@ private PaGetPaymentRes generatePaGetPaymentResponse(
     PaGetPaymentRes response = factory.createPaGetPaymentRes();
     CtPaymentPA responseData = factory.createCtPaymentPA();
     CtTransferListPA transferList = factory.createCtTransferListPA();
-    CtMetadata paymentOptionMetadata = factory.createCtMetadata();
 
     response.setOutcome(StOutcome.OK);
 
@@ -384,11 +383,15 @@ private PaGetPaymentRes generatePaGetPaymentResponse(
     CtSubject debtor = this.getDebtor(source);
     responseData.setDebtor(debtor);
 
-    List<CtMapEntry> poMapEntry = paymentOptionMetadata.getMapEntry();
-    for (PaymentOptionMetadataModel po : source.getPaymentOptionMetadata()) {
-      poMapEntry.add(getPaymentOptionMetadata(po));
+    List<PaymentOptionMetadataModel> paymentOptionMetadataModels = source.getPaymentOptionMetadata();
+    if (paymentOptionMetadataModels != null && !paymentOptionMetadataModels.isEmpty()) {
+      CtMetadata paymentOptionMetadata = factory.createCtMetadata();
+      List<CtMapEntry> poMapEntry = paymentOptionMetadata.getMapEntry();
+      for (PaymentOptionMetadataModel po : paymentOptionMetadataModels) {
+        poMapEntry.add(getPaymentOptionMetadata(po));
+      }
+      responseData.setMetadata(paymentOptionMetadata);
     }
-    responseData.setMetadata(paymentOptionMetadata);
 
     // Transfer list
     transferList
@@ -425,7 +428,6 @@ private PaGetPaymentV2Response generatePaGetPaymentResponse(
     PaGetPaymentV2Response response = factory.createPaGetPaymentV2Response();
     CtPaymentPAV2 responseData = factory.createCtPaymentPAV2();
     CtTransferListPAV2 transferList = factory.createCtTransferListPAV2();
-    CtMetadata paymentOptionMetadata = factory.createCtMetadata();
 
     response.setOutcome(StOutcome.OK);
 
@@ -445,11 +447,15 @@ private PaGetPaymentV2Response generatePaGetPaymentResponse(
     responseData.setCompanyName(Optional.ofNullable(source.getCompanyName()).orElse("NA"));
     responseData.setOfficeName(Optional.ofNullable(source.getOfficeName()).orElse(("NA")));
 
-    List<CtMapEntry> poMapEntry = paymentOptionMetadata.getMapEntry();
-    for (PaymentOptionMetadataModel po : source.getPaymentOptionMetadata()) {
-      poMapEntry.add(getPaymentOptionMetadata(po));
+    List<PaymentOptionMetadataModel> paymentOptionMetadataModels = source.getPaymentOptionMetadata();
+    if(paymentOptionMetadataModels != null && !paymentOptionMetadataModels.isEmpty()) {
+      CtMetadata paymentOptionMetadata = factory.createCtMetadata();
+      List<CtMapEntry> poMapEntry = paymentOptionMetadata.getMapEntry();
+      for (PaymentOptionMetadataModel po : paymentOptionMetadataModels) {
+        poMapEntry.add(getPaymentOptionMetadata(po));
+      }
+      responseData.setMetadata(paymentOptionMetadata);
     }
-    responseData.setMetadata(paymentOptionMetadata);
 
     // debtor data
     CtSubject debtor = this.getDebtor(source);
@@ -530,12 +536,15 @@ private CtTransferPA getTransferResponse(
     transferPA.setTransferAmount(BigDecimal.valueOf(transfer.getAmount()));
     transferPA.setTransferCategory(transfer.getCategory());
 
-    CtMetadata ctMetadata = new CtMetadata();
-    List<CtMapEntry> transferMapEntry = ctMetadata.getMapEntry();
-    for (TransferMetadataModel transferMetadataModel : transfer.getTransferMetadata()) {
-      transferMapEntry.add(getTransferMetadata(transferMetadataModel));
+    List<TransferMetadataModel> transferMetadataModels = transfer.getTransferMetadata();
+    if(transferMetadataModels != null && !transferMetadataModels.isEmpty()) {
+      CtMetadata ctMetadata = new CtMetadata();
+      List<CtMapEntry> transferMapEntry = ctMetadata.getMapEntry();
+      for (TransferMetadataModel transferMetadataModel : transferMetadataModels) {
+        transferMapEntry.add(getTransferMetadata(transferMetadataModel));
+      }
+      transferPA.setMetadata(ctMetadata);
     }
-    transferPA.setMetadata(ctMetadata);
 
     return transferPA;
   }
@@ -558,12 +567,15 @@ private CtTransferPAV2 getTransferResponseV2(
     transferPA.setTransferAmount(BigDecimal.valueOf(transfer.getAmount()));
     transferPA.setTransferCategory(transfer.getCategory());
 
-    CtMetadata ctMetadata = new CtMetadata();
-    List<CtMapEntry> transferMapEntry = ctMetadata.getMapEntry();
-    for (TransferMetadataModel transferMetadataModel : transfer.getTransferMetadata()) {
-      transferMapEntry.add(getTransferMetadata(transferMetadataModel));
+    List<TransferMetadataModel> transferMetadataModels = transfer.getTransferMetadata();
+    if(transferMetadataModels != null && !transferMetadataModels.isEmpty()) {
+      CtMetadata ctMetadata = new CtMetadata();
+      List<CtMapEntry> transferMapEntry = ctMetadata.getMapEntry();
+      for (TransferMetadataModel transferMetadataModel : transferMetadataModels) {
+        transferMapEntry.add(getTransferMetadata(transferMetadataModel));
+      }
+      transferPA.setMetadata(ctMetadata);
     }
-    transferPA.setMetadata(ctMetadata);
 
     return transferPA;
   }