Feature: add signal mesh creation #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By aligning the upstream signal implementation with our own approach.
|
I would further like to suggest renaming of the class |
|
Looks really good! Thanks for providing this. I merged this into the viewer and verified that the signals look good. You can ahead and change |
|
I would appreciate if you also create a new version/release tag after merging this signal feature into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We extend the current signal implementation with creation of signal meshes. Additionally, these signal meshes are added to the OpenDriveMap and also parsed in
test.cpp.This feature contributes to #21.