url2purl: handle pypi.org urls #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pypi.org replaced pypi.python.org in 2017 and so most urls are now using this. See: https://packaging.python.org/en/latest/glossary/#term-pypi.org Make sure we route this domain properly so that we don't generate generic purls. Input: https://pypi.org/packages/source/z/zc.recipe.egg/zc.recipe.egg-2.0.0.tar.gz Before: pkg:generic/zc.recipe.egg-2.0.0.tar.gz?download... After: pkg:pypi/zc.recipe.egg@2.0.0
Some tools are reporting `https://pypi.org/project/<name>/<version>` urls for pypi packages, let's make sure we can generate proper purls. Input: https://pypi.org/project/widgetsnbextension/3.0.7 Before: pkg:generic/3.0.7?download_url=... After: pkg:pypi/widgetsnbextension@3.0.7
pombredanne
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Neat and clean....and works nicely with package-url/purl-spec#250 (review)
Thank you ++
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Dec 11, 2023
0.12.0 (2023-12-08) ------------------- - Modified `PackageURL.from_string` to properly handle golang purls. package-url/packageurl-python#115 - Improve support for PyPI URLs in `url2purl`. package-url/packageurl-python#128 - Return the "gem" type instead of "rubygems" for "https://rubygems.org/" URLs in `url2purl`. The `pkg:rubygems/` purls are backward-compatible in `purl2url`. package-url/packageurl-python#114 0.11.3 (2023-12-08) -------------------- - Add support for GitLab "/archive/" URLs in `url2purl`. package-url/packageurl-python#133
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pypi.org replaced pypi.python.org in 2017 and so most urls are now using this.
See: https://packaging.python.org/en/latest/glossary/#term-pypi.org
Make sure we route this domain properly so that we don't generate generic purls.
Input: https://pypi.org/packages/source/z/zc.recipe.egg/zc.recipe.egg-2.0.0.tar.gz
Before: pkg:generic/zc.recipe.egg-2.0.0.tar.gz?download...
After: pkg:pypi/zc.recipe.egg@2.0.0