Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: link settings_test_fs with kernel #3

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

tejlmand
Copy link

This is patch to zephyrproject-rtos#29618 to specifically link settings_test_fs with
kernel library.

This is needed because Zephyr libraries created after
find_package(Zephyr) are not pure Zephyr libraries, as they are not
in the whole-archive linking grouping.

Signed-off-by: Torsten Rasmussen Torsten.Rasmussen@nordicsemi.no

This is patch to zephyrproject-rtos#29618 to specifically link settings_test_fs with
kernel library.

This is needed because Zephyr libraries created after
`find_package(Zephyr)` are not pure Zephyr libraries, as they are not
in the `whole-archive` linking grouping.

Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
Copy link
Owner

@pabigot pabigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, that's the trick I didn't know to try.

Looks good, but please remove this from the commit message:

This is patch to #29618 to specifically link settings_test_fs with
kernel library.

It doesn't seem useful to have that in the permanent record. Or I can remove it and merge by hand, your choice.

@pabigot pabigot merged this pull request into pabigot:nordic/work2 Jan 21, 2021
@tejlmand
Copy link
Author

I wasn't sure how you wanted to take in the patch.
As-is or squash into earlier commit, so I just made the description according to what I fixed ;)
So always feel free to adjust, as you find fit.

@pabigot
Copy link
Owner

pabigot commented Jan 22, 2021

So always feel free to adjust, as you find fit.

Thanks; I'll keep that in mind going forward. I don't merge PRs submitted on github because it screws up the way I manage branches locally; it's easier to fetch from another repository and cherry-pick. So you can always just push a branch and directly or in a comment send me a link to it, e.g. https://github.com/tejlmand/zephyr/tree/reviews/29618_proposal.

@tejlmand tejlmand deleted the reviews/29618_proposal branch January 22, 2021 13:22
@tejlmand
Copy link
Author

will remember.
There are many different ways of handling suggestions/fixes, and you can still cherry-pick the commit directly from the branch, no need for merging the PR, if it doesn't fit your workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants