Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixture: review proposal for #30594 #2

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions boards/arc/em_starterkit/em_starterkit.dts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,3 @@
status = "okay";
current-speed = <115200>;
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/atsamd21_xpro/atsamd21_xpro.dts
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,3 @@
&usb0 {
status = "okay";
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/cc1352r1_launchxl/cc1352r1_launchxl.dts
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,3 @@
&rtc {
status = "okay";
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/cc3220sf_launchxl/cc3220sf_launchxl.dts
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,3 @@
status = "okay";
clock-frequency = <I2C_BITRATE_FAST>;
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/cc3235sf_launchxl/cc3235sf_launchxl.dts
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,3 @@
status = "okay";
clock-frequency = <I2C_BITRATE_FAST>;
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/disco_l475_iot1/disco_l475_iot1.dts
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,3 @@
&adc1_in14_pc5>;
status = "okay";
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/efr32mg_sltb004a/efr32mg_sltb004a.dts
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,3 @@
&trng0 {
status = "okay";
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/frdm_k64f/frdm_k64f.dts
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,3 @@ arduino_spi: &spi0 {
&pit0 {
status = "okay";
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/lpcxpresso54114/lpcxpresso54114_m4.dts
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,3 @@
&flexcomm5 {
status = "okay";
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures_m4.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/lpcxpresso55s69/lpcxpresso55s69_cpu0.dts
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,3 @@
dma-channels = <20>;
status = "okay";
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/mec15xxevb_assy6853/mec15xxevb_assy6853.dts
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,3 @@
&tach0 {
status = "okay";
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/mimxrt1050_evk/mimxrt1050_evk.dts
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,3 @@ arduino_serial: &lpuart3 {};
&wdog0 {
status = "okay";
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/mimxrt1060_evk/mimxrt1060_evk.dts
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,3 @@ arduino_serial: &lpuart3 {};
&wdog0 {
status = "okay";
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/mimxrt685_evk/mimxrt685_evk_cm33.dts
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,3 @@ arduino_spi: &flexcomm5 {
&red_led {
status = "okay";
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures_cm33.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/npcx7m6fb_evb/npcx7m6fb_evb.dts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,3 @@
&espi0 {
status = "okay";
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/nrf52840dk_nrf52840/nrf52840dk_nrf52840.dts
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,3 @@ arduino_spi: &spi3 {
compatible = "nordic,nrf-usbd";
status = "okay";
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/nucleo_f030r8/nucleo_f030r8.dts
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,3 @@
&iwdg {
status = "okay";
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/nucleo_f091rc/nucleo_f091rc.dts
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,3 @@
status = "okay";
pinctrl-0 = <&dac_out1_pa4>;
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/nucleo_f207zg/nucleo_f207zg.dts
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,3 @@
status = "okay";
pinctrl-0 = <&dac_out1_pa4>;
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/nucleo_f334r8/nucleo_f334r8.dts
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,3 @@
};
};
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/nucleo_f401re/nucleo_f401re.dts
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,3 @@
&wwdg {
status = "okay";
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/nucleo_f429zi/nucleo_f429zi.dts
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,3 @@

};
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/nucleo_f746zg/nucleo_f746zg.dts
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,3 @@
&eth_txd0_pg13
&eth_txd1_pb13>;
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/nucleo_g071rb/nucleo_g071rb.dts
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,3 @@
status = "okay";
clock-frequency = <I2C_BITRATE_FAST>;
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/nucleo_g474re/nucleo_g474re.dts
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,3 @@
pinctrl-0 = <&adc1_in1_pa0>;
status = "okay";
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/nucleo_l053r8/nucleo_l053r8.dts
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,3 @@
&eeprom {
status = "okay";
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/nucleo_l073rz/nucleo_l073rz.dts
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,3 @@
status = "okay";
pinctrl-0 = <&dac_out1_pa4>;
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/nucleo_l152re/nucleo_l152re.dts
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,3 @@
status = "okay";
pinctrl-0 = <&dac_out1_pa4>;
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/nucleo_l476rg/nucleo_l476rg.dts
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,3 @@
pinctrl-0 = <&adc1_in1_pc0>;
status = "okay";
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/nucleo_l4r5zi/nucleo_l4r5zi.dts
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,3 @@
pinctrl-0 = <&adc1_in1_pc0>;
status = "okay";
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/nucleo_wb55rg/nucleo_wb55rg.dts
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,3 @@

};
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/stm32f3_disco/stm32f3_disco.dts
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,3 @@
pinctrl-0 = <&adc1_in1_pa0>;
status = "okay";
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/stm32h747i_disco/stm32h747i_disco_m7.dts
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,3 @@
};
};
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures_m7.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/stm32mp157c_dk2/stm32mp157c_dk2.dts
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,3 @@
status = "okay";
clock-frequency = <I2C_BITRATE_FAST>;
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/thingy52_nrf52832/thingy52_nrf52832.dts
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,3 @@
};
};
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/arm/udoo_neo_full_m4/udoo_neo_full_m4.dts
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,3 @@
&epit2 {
status = "okay";
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/riscv/hifive1_revb/hifive1_revb.dts
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,3 @@ arduino_i2c: &i2c0 {
input-frequency = <16000000>;
clock-frequency = <100000>;
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/riscv/rv32m1_vega/rv32m1_vega_ri5cy.dts
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,3 @@
};
};
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures_ri5cy.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/x86/up_squared/up_squared.dts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,3 @@
zephyr,bt-mon-uart = &uart1;
};
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
4 changes: 0 additions & 4 deletions boards/xtensa/esp32/esp32.dts
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,3 @@
&trng0 {
status = "okay";
};

#ifdef DTS_INCLUDE_FIXTURES
#include "fixtures.dtsi"
#endif /* DTS_INCLUDE_FIXTURES */
File renamed without changes.
15 changes: 15 additions & 0 deletions tests/common/boards/sam_e70b_xplained.overlay
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
/*
* Copyright (c) 2020 Nordic Semiconductor ASA
*
* SPDX-License-Identifier: Apache-2.0
*/

/ {
zephyr,fixture {
gpio-loopback {
compatible = "zephyr,fixture,gpio-loopback";
out-gpios = <&piod 21 0>;
in-gpios = <&piod 20 0>;
};
};
};
11 changes: 9 additions & 2 deletions tests/drivers/gpio/gpio_basic_api/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,15 @@

cmake_minimum_required(VERSION 3.13.1)

# This test requires devicetree fixture support
set(DTS_EXTRA_CPPFLAGS "-DDTS_INCLUDE_FIXTURES")
# This manually adds a DTC overlay file if such exists in
# tests/common/gpio-fixture/boards for the board.
# This breaks what is documented regarding inclusion of overlay files:
# https://docs.zephyrproject.org/latest/guides/dts/howtos.html#set-devicetree-overlays
# so in case this approach is taken, it should be documented properly.
# As long as this principle is only used under tests/ it is acceptable.
zephyr_file(CONF_FILES ${ZEPHYR_BASE}/tests/common/gpio-fixture/boards
DTS DTC_OVERLAY_FILE
)

find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE})
project(gpio_basic_api)
Expand Down
Loading