You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
will result in failure to process the structure flags field because the intended property name is interpreted as the rarely-used second parameter boolean specifying the bit order, leaving the field without a property name and so with no way to represent the field content.
If the second parameter to lo.bits is a string and there is no third parameter, treat the second parameter as property and set msb to undefined.
The text was updated successfully, but these errors were encountered:
pabigot
changed the title
BitStructure: improve argument processing
BitStructure: improve constructor argument processing
Dec 23, 2017
BitStructure's constructor takes two parameters, with the second being a
rarely-used option to order allocation from the most significant bit
down. The developer forgets this, and passes a property name without a
second argument, which results in no data. If the argument is
type-compatible with property and no third argument is present, treat
the argument as property rather than msb.
Technically this is an API change, but I'm going to rule it minor
because anybody who's affected will have been using it wrong.
Closes#17.
This code:
will result in failure to process the structure
flags
field because the intended property name is interpreted as the rarely-used second parameter boolean specifying the bit order, leaving the field without a property name and so with no way to represent the field content.If the second parameter to
lo.bits
is a string and there is no third parameter, treat the second parameter asproperty
and setmsb
toundefined
.The text was updated successfully, but these errors were encountered: