-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes retina issues on the mac #49
Conversation
This looks very good and works perfectly on my machine. @Manindra29, were you able to run some tests as well? |
I tried it on my machine today. I ran a bunch of sketches in the examples. The frame rates look much better! This is great @antiboredom! But I did notice some screen tearing. For example in interpolate.py. Did anyone else notice the same? Not sure if this PR necessarily causes it, because frame rates were too low on Mac for the tearing to be noticeable without this PR. |
I don't notice any tearing. That can be worked on later, though. At least the sketches now work on Mac :) |
@@ -62,6 +56,10 @@ | |||
config=config, | |||
) | |||
|
|||
actual_width, actual_height = window.get_viewport_size() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to break the documentation auto-generation (see #50) I've pushed a fix on the fix-50-doc-autogen
branch, can you see if it still works as expected on the Mac?
@Manindra29, @antiboredom, could you try testing out the fix in the documentation generation (see #50) in |
The documentation build passed with #50 on my machine. |
@abhikpal I wasn't able to build the docs, but I think it's related to me messing up my python installation. That said everything else seems to work... |
This also includes the framerate fix by @parsoyaarihant.