Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes retina issues on the mac #49

Merged
merged 1 commit into from
Jul 18, 2018
Merged

Fixes retina issues on the mac #49

merged 1 commit into from
Jul 18, 2018

Conversation

antiboredom
Copy link
Contributor

This also includes the framerate fix by @parsoyaarihant.

@abhikpal
Copy link
Member

This looks very good and works perfectly on my machine. @Manindra29, were you able to run some tests as well?

@Manindra29
Copy link
Contributor

I tried it on my machine today. I ran a bunch of sketches in the examples. The frame rates look much better! This is great @antiboredom!

But I did notice some screen tearing. For example in interpolate.py. Did anyone else notice the same? Not sure if this PR necessarily causes it, because frame rates were too low on Mac for the tearing to be noticeable without this PR.

@abhikpal
Copy link
Member

abhikpal commented Jun 4, 2018

But I did notice some screen tearing. For example in interpolate.py. Did anyone else notice the same?

I don't notice any tearing. That can be worked on later, though. At least the sketches now work on Mac :)

@@ -62,6 +56,10 @@
config=config,
)

actual_width, actual_height = window.get_viewport_size()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to break the documentation auto-generation (see #50) I've pushed a fix on the fix-50-doc-autogen branch, can you see if it still works as expected on the Mac?

@abhikpal
Copy link
Member

abhikpal commented Jun 5, 2018

@Manindra29, @antiboredom, could you try testing out the fix in the documentation generation (see #50) in fix-50-doc-autogen on your respective computers?

@abhikpal abhikpal added this to the Pre-VisPy release milestone Jun 5, 2018
@abhikpal abhikpal self-assigned this Jun 5, 2018
@Manindra29
Copy link
Contributor

The documentation build passed with #50 on my machine.

@antiboredom
Copy link
Contributor Author

@abhikpal I wasn't able to build the docs, but I think it's related to me messing up my python installation. That said everything else seems to work...

@abhikpal abhikpal modified the milestones: Pre-VisPy release, Port backend to VisPy Jun 12, 2018
@abhikpal abhikpal merged commit 69157d1 into p5py:master Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants