Removed pyglet.window.get_platform() #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pyglets `platform` API has been depriciated hence it should not be used. `config` (defined in line 46) is created using `screen`.
|
Hmm. interesting. This seems to break on my machine (Debian 9 running on a ThinkPad)... The window opens but fails to display anything. I do see some grey boxes occasionally, though. Here's what I get: |
|
Can you show your |
|
@abhikpal , I have pushed a new commit in this PR. Can you check if this new configuration works on your computer? |
based on the comments by @kevinstadler I haved added double_buffer=1, sample_buffers=1. See: p5py#10 (comment)
|
Ping @abhikpal . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10 .
I contacted Pyglet community on bitbucket and they said that
platform. API has been depreciated and will be removed soon : https://bitbucket.org/pyglet/pyglet/issues/175/pyglet-config-error-in-pygletwindowwindowBased on the Pyglet community response, I have updated the code accordingly and it works as expected on Mac.