Fix vertex transformation in 2D renderer #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah that makes total sense. Looks like I forgot to renormalize the coordinates to make the last component 1. Thank you! |
|
@janbehrens @ziyaointl I was setting up some 3D tests and changes in this PR is breaking the 3D rendering pipeline. You could refer to the 3D sketch test in #318 and check for errors. |
ziyaointl
pushed a commit
that referenced
this pull request
Aug 18, 2021
Also disabled exception interception in vispy; reverted #308.
ziyaointl
added a commit
that referenced
this pull request
Aug 19, 2021
ziyaointl
added a commit
that referenced
this pull request
Aug 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how I resolved #307. Let me know if it makes any sense.