Fix push_matrix, drop pop_matrix and pop_style #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use with:, drop pop_matrix()
|
@parsoyaarihant @abhikpal -- I'm requesting a review. This should be very quick to look over and either approve or ask for changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes pop_matrix() and pop_style(), which were unnecessary (push_matrix and push_style are context managers) and were incorrectly implemented.
It also corrects all the bad documentation and example code, which was incorrectly demonstrating push_matrix as a non-context manager (wrong) followed by pop_matrix (wrong, shouldn't be used). This includes narrative explanations from the 2D tutorial.
Closes #156
Resolves #147