🐛 fix: bring back tracking & prevent multiple unwanted renders #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #954 +/- ##
==========================================
+ Coverage 78.18% 78.37% +0.19%
==========================================
Files 7 7
Lines 110 111 +1
Branches 15 14 -1
==========================================
+ Hits 86 87 +1
- Misses 22 24 +2
+ Partials 2 0 -2 ☔ View full report in Codecov by Sentry. |
antoinechassagne
approved these changes
Nov 25, 2024
emileNetter
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with tracking when
cookies_enabledchanges.It also fixes an issue with multiple paywalls sometimes appearing on
cookies_enabledchanges.