refactor: various type issues

p3ol · Jun 3, 2024 · 8bfffc4 · 8bfffc4
1 parent b1cc9a9
commit 8bfffc4
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -40,6 +40,7 @@
     "@testing-library/user-event": "14.5.2",
     "@types/d3": "7.4.3",
     "@types/jest": "29.5.12",
+    "@types/node": "20.14.0",
     "@typescript-eslint/parser": "7.1.0",
     "autoprefixer": "10.4.17",
     "babel-jest": "29.7.0",

diff --git a/packages/core/rollup.config.ts b/packages/core/rollup.config.ts
@@ -19,7 +19,7 @@ const defaultPlugins = [
   terser(),
 ];
 
-const defaultExternals = [];
+const defaultExternals: string[] = [];
 const defaultGlobals = {};
 
 export default [

diff --git a/packages/transitions/rollup.config.ts b/packages/transitions/rollup.config.ts
@@ -67,7 +67,7 @@ export default [
       sourcemap: true,
       globals: defaultGlobals,
       ...(f === 'esm' ? {
-        manualChunks: id =>
+        manualChunks: (id: string) =>
           id.includes('node_modules') ? 'vendor' : path.parse(id).name,
       } : {}),
     },

diff --git a/tsconfig.json b/tsconfig.json
@@ -4,7 +4,7 @@
     "baseUrl": ".",
     "jsx": "react-jsx",
     "esModuleInterop": true,
-    "types": ["jest"],
+    "types": ["jest", "node"],
     "lib": ["DOM", "ES2022"],
     "noImplicitAny": true,
     "module": "esnext",

diff --git a/yarn.lock b/yarn.lock
@@ -5382,6 +5382,15 @@ __metadata:
   languageName: node
   linkType: hard
 
+"@types/node@npm:20.14.0":
+  version: 20.14.0
+  resolution: "@types/node@npm:20.14.0"
+  dependencies:
+    undici-types: "npm:~5.26.4"
+  checksum: 10c0/29ccc7592e9ca6b81d00f3a6673241d08e9042d801b10adfd9ebcbbf326208e0a0133a8d146158db18d02a68b85d9ce1fd94e6e1e5be0da263129bf6e42eb22d
+  languageName: node
+  linkType: hard
+
 "@types/node@npm:^18.0.0":
   version: 18.19.18
   resolution: "@types/node@npm:18.19.18"
@@ -15370,6 +15379,7 @@ __metadata:
     "@testing-library/user-event": "npm:14.5.2"
     "@types/d3": "npm:7.4.3"
     "@types/jest": "npm:29.5.12"
+    "@types/node": "npm:20.14.0"
     "@typescript-eslint/parser": "npm:7.1.0"
     autoprefixer: "npm:10.4.17"
     babel-jest: "npm:29.7.0"