fix(select-field): update internal value when options change

p3ol · Dec 5, 2019 · 14200d6 · 14200d6
1 parent 75b8218
commit 14200d6
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/src/SelectField.js b/src/SelectField.js
@@ -93,6 +93,10 @@ class SelectField extends React.Component {
       this.onPropValueChange();
     }
 
+    if (prevProps.options !== this.props.options) {
+      this.onPropValueChange(false);
+    }
+
     if (prevProps.disabled !== this.props.disabled && this.props.disabled) {
       this.setState({
         opened: false,

diff --git a/tests/SelectField.test.js b/tests/SelectField.test.js
@@ -215,4 +215,26 @@ describe('<SelectField />', () => {
     component.find(DropdownItem).at(0).find('a').simulate('click');
     expect(component.instance().getValue()).toBe('Five');
   });
+
+  it('should update internal value when options change', () => {
+    const component = mount(
+      <SelectField
+        options={[]}
+        value={5}
+        parseValue={opt => opt.value}
+      />
+    );
+
+    expect(component.instance().getValue()).not.toBeDefined();
+
+    component.setProps({
+      options: [
+        { title: 'Four', value: 4 },
+        { title: 'Five', value: 5 },
+        { title: 'Six', value: 6 },
+      ],
+    });
+
+    expect(component.instance().getValue()).toBe(5);
+  });
 });