Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IO checks, HiFi-UI and dependencies improvements #128

Merged
merged 186 commits into from
Feb 5, 2024
Merged

IO checks, HiFi-UI and dependencies improvements #128

merged 186 commits into from
Feb 5, 2024

Conversation

VideoMem
Copy link
Collaborator

@VideoMem VideoMem commented Feb 4, 2024

Adds better file I/O checks.

When input file/output file are specified, tries to read input and open output, if these test fails it prints a proper message and ends.
When HiFi-UI is used it doesn't enforce input and output file checks until start of decoding.

Updates minimum numba, numpy and scipy versions.
Found weird issues if any of these versions is lower than the ones specified.

VideoMem added 30 commits March 23, 2021 16:07
@VideoMem
Merge of vhs_decode branch
b4b72a3 
Signed-off-by: Sebastian Wilwerth <sebastian.wilwerth@gmail.com>
@VideoMem
typo glitch fix
0756c7c 
Signed-off-by: Sebastian Wilwerth <sebastian.wilwerth@gmail.com>
@VideoMem
DC restore intro
a9d9471 
Signed-off-by: Sebastian Wilwerth <sebastian.wilwerth@gmail.com>
@VideoMem
DC restore, before sync restore
ca2e427 
Signed-off-by: Sebastian Wilwerth <sebastian.wilwerth@gmail.com>
@VideoMem
DC restore improved metrics
25086fc 
Signed-off-by: Sebastian Wilwerth <sebastian.wilwerth@gmail.com>
@VideoMem
DC restore improved metrics, pre merge check
f37d4b0 
Signed-off-by: Sebastian Wilwerth <sebastian.wilwerth@gmail.com>
@VideoMem
Merge remote-tracking branch 'upstream/vhs_decode' into vhs_decode
6fab92b
@VideoMem
Added chroma trap option to cvbs-decode
2498807 
Signed-off-by: Sebastian Wilwerth <sebastian.wilwerth@gmail.com>
@VideoMem
Auto-sync level, first try
6e94ede 
Signed-off-by: Sebastian Wilwerth <sebastian.wilwerth@gmail.com>
@VideoMem
Auto-sync level, added to cvbs + wavesink
13c7a2c 
Signed-off-by: Sebastian Wilwerth <sebastian.wilwerth@gmail.com>
@VideoMem
Auto-sync level (block level, not working) , added to cvbs + wavesink
13dc289 
Signed-off-by: Sebastian Wilwerth <sebastian.wilwerth@gmail.com>
@VideoMem
Auto-sync level (block level, not working) , added to cvbs + wavesink
997edff 
Signed-off-by: Sebastian Wilwerth <sebastian.wilwerth@gmail.com>
@VideoMem
Merge branch 'vhs_decode' of github.com:oyvindln/ld-decode into vhs_d…
3c51017 
…ecode

Signed-off-by: Sebastian Wilwerth <sebastian.wilwerth@gmail.com>

# Conflicts:
#	vhsdecode/process.py
@VideoMem
Merge branch 'vhs_decode' of github.com:oyvindln/ld-decode into vhs_d…
e5c8e63 
…ecode

Signed-off-by: Sebastian Wilwerth <sebastian.wilwerth@gmail.com>

# Conflicts:
#	vhsdecode/process.py (solved)
@VideoMem
Some dead code removal
a692707 
Signed-off-by: Sebastian Wilwerth <sebastian.wilwerth@gmail.com>
@VideoMem
Previous merge commit
b571a05 
Signed-off-by: Sebastian Wilwerth <sebastian.wilwerth@gmail.com>
@VideoMem
Merge remote-tracking branch 'upstream/vhs_decode' into vhs_decode
79d8c3e
@VideoMem
Merge of oyvindln/vhs_decode changes
20444ee 
Signed-off-by: Sebastian Wilwerth <sebastian.wilwerth@gmail.com>
@VideoMem
Merge remote-tracking branch 'upstream/vhs_decode' into vhs_decode
41cb814
@VideoMem
Resync
b0e0248 
Signed-off-by: Sebastian Wilwerth <sebastian.wilwerth@gmail.com>
@VideoMem
Merge branch 'vhs_decode' of github.com:oyvindln/ld-decode into vhs_d…
90a9afb 
…ecode
@VideoMem
Moved experimental sync separator code to resync branch
12fa31f 
Signed-off-by: Sebastian Wilwerth <sebastian.wilwerth@gmail.com>
@VideoMem
Merge remote-tracking branch 'upstream/vhs_decode' into resync
7f68321
@VideoMem
Merge branch 'vhs_decode' into resync
9532e76 
# Conflicts:
#	cvbsdecode/process.py
#	vhsdecode/process.py
@VideoMem
Restored deleted files
0c293c9 
Signed-off-by: Sebastian Wilwerth <sebastian.wilwerth@gmail.com>
@VideoMem
Comment typo fix
22de0b8 
Signed-off-by: Sebastian Wilwerth <sebastian.wilwerth@gmail.com>
@VideoMem
Comment typo fix
713b963 
Signed-off-by: Sebastian Wilwerth <sebastian.wilwerth@gmail.com>
@VideoMem
Merge branch 'vhs_decode' of github.com:oyvindln/ld-decode into vhs_d…
6268034 
…ecode
@VideoMem
Merge branch 'vhs_decode' into resync
1439865
@VideoMem
getpulses_override() keep the last valid blacklevel, synclevel, and v…
b186a26 
…sync_locs for use in the case where they cannot be measured on the current field.

Fixes some bad signal cases.

Signed-off-by: Sebastian Wilwerth <sebastian.wilwerth@gmail.com>
@VideoMem
Adds hifi-decode to setup.py
3683a59 
Signed-off-by: VideoMem <sebastian.wilwerth@gmail.com>
@VideoMem
Fixes unwanted changes on cmdcommons.py
e30edab 
Signed-off-by: VideoMem <sebastian.wilwerth@gmail.com>
@VideoMem
Merge remote-tracking branch 'upstream/vhs_decode' into vhs_decode
6a6596b 
# Conflicts:
#	hifi-decode
#	setup.py
#	vhsdecode/addons/FMdeemph.py
#	vhsdecode/cmdcommons.py
@VideoMem
Adds stdin input using - as input filename.
9284b80 
Fixes denominator limits that may cause bad samplerate conversion.
Applies LogCompander.expand() only to sidechain signal.

Signed-off-by: VideoMem <sebastian.wilwerth@gmail.com>
@VideoMem
Reconfigures NR sidechain gain to higher value.
e29494a 
Adds audio_rate param (not working yet)

Signed-off-by: VideoMem <sebastian.wilwerth@gmail.com>
@VideoMem
Fixes --audio_rate parameter.
b994f6e 
Some speed optimizations.

Signed-off-by: VideoMem <sebastian.wilwerth@gmail.com>
@VideoMem
Merge branch 'vhs_decode' of github.com:oyvindln/ld-decode into vhs_d…
945f51a 
…ecode
@VideoMem
Updates HiFiDecode header text comment
b67e369 
Signed-off-by: VideoMem <sebastian.wilwerth@gmail.com>
@VideoMem
Overrides file close method for stdin to do nothing.
397252c 
Signed-off-by: VideoMem <sebastian.wilwerth@gmail.com>
@VideoMem
Fixes crackling sound when reading from stdin.
cff7233 
Adjusts block size for speed improvements.
Adds gain/volume parameter

Signed-off-by: VideoMem <sebastian.wilwerth@gmail.com>
@VideoMem
Merge from oln's branch
f85d2c4
@VideoMem
Adjusts block size for speed improvements.
10e9897 
Signed-off-by: VideoMem <sebastian.wilwerth@gmail.com>
@VideoMem
Fixes bug in --preview parameter
8e6f445 
Signed-off-by: VideoMem <sebastian.wilwerth@gmail.com>
@VideoMem
Fixes bug in audio dc bias cancel
796f5c9 
Signed-off-by: VideoMem <sebastian.wilwerth@gmail.com>
@VideoMem
Adds hifi-decode UI
6fa4c03 
Signed-off-by: VideoMem <sebastian.wilwerth@gmail.com>
@VideoMem
Adds audio modes and ld-ldf-reader for (optional) input file decoding.
a2f104b 
Signed-off-by: VideoMem <sebastian.wilwerth@gmail.com>
@VideoMem
Audio sample_rate default is 44100
b9bb089 
Signed-off-by: VideoMem <sebastian.wilwerth@gmail.com>
@VideoMem
Merge remote-tracking branch 'upstream/vhs_decode' into vhs_decode
0e1a386 
# Conflicts:
#	vhsdecode/hifi/main.py
@VideoMem
Removes pyhht dependency from HiFi decode to make it portable to Wind…
f769632 
…ows.

Adjusts ld-ldf-reader detection logic.

Signed-off-by: VideoMem <sebastian.wilwerth@gmail.com>
@VideoMem
Merge remote-tracking branch 'upstream/vhs_decode' into vhs_decode
0e24e0f 
# Conflicts:
#	pyproject.toml
#	requirements.txt
#	vhsdecode/hifi/main.py
@VideoMem
Adds better validation checks for input / output filenames.
692a863 
Updates numba, numpy and scipy minimum versions.
Makes infile, outfile optional when on UI (hifi-decode)

Signed-off-by: VideoMem <sebastian.wilwerth@gmail.com>
@VideoMem
Fixes AttributeError for os.statvfs on Windows
0d35196 
Signed-off-by: VideoMem <sebastian.wilwerth@gmail.com>
@VideoMem VideoMem requested a review from oyvindln February 4, 2024 22:10
VideoMem and others added 3 commits February 4, 2024 19:14
@VideoMem
Fixes a typo
3fb7399 
Signed-off-by: VideoMem <sebastian.wilwerth@gmail.com>
@VideoMem
Tries a fix that prevents file opening on windows
549d553 
Signed-off-by: VideoMem <sebastian.wilwerth@gmail.com>
@oyvindln
Merge branch 'vhs_decode' into vhs_decode
0746cf1
@oyvindln oyvindln merged commit 66b399e into oyvindln:vhs_decode Feb 5, 2024
0 of 2 checks passed
JuniorIsAJitterbug pushed a commit to JuniorIsAJitterbug/vhs-decode that referenced this pull request Feb 13, 2024
@VideoMem @oyvindln @JuniorIsAJitterbug
IO checks, HiFi-UI and dependencies improvements (oyvindln#128)
3fdc118 
* Adds better validation checks for input / output filenames.
Updates numba, numpy and scipy minimum versions.
Makes infile, outfile optional when on UI (hifi-decode)


Signed-off-by: Sebastian Wilwerth <sebastian.wilwerth@gmail.com>
Signed-off-by: VideoMem <sebastian.wilwerth@gmail.com>
Co-authored-by: oyvindln <oyvindln@users.noreply.github.com>
JuniorIsAJitterbug pushed a commit to JuniorIsAJitterbug/vhs-decode that referenced this pull request Feb 18, 2024
@VideoMem @oyvindln @JuniorIsAJitterbug
IO checks, HiFi-UI and dependencies improvements (oyvindln#128)
f60afe1 
* Adds better validation checks for input / output filenames.
Updates numba, numpy and scipy minimum versions.
Makes infile, outfile optional when on UI (hifi-decode)


Signed-off-by: Sebastian Wilwerth <sebastian.wilwerth@gmail.com>
Signed-off-by: VideoMem <sebastian.wilwerth@gmail.com>
Co-authored-by: oyvindln <oyvindln@users.noreply.github.com>
JuniorIsAJitterbug pushed a commit to JuniorIsAJitterbug/vhs-decode that referenced this pull request Feb 22, 2024
@VideoMem @oyvindln @JuniorIsAJitterbug
IO checks, HiFi-UI and dependencies improvements (oyvindln#128)
ef908c2 
* Adds better validation checks for input / output filenames.
Updates numba, numpy and scipy minimum versions.
Makes infile, outfile optional when on UI (hifi-decode)


Signed-off-by: Sebastian Wilwerth <sebastian.wilwerth@gmail.com>
Signed-off-by: VideoMem <sebastian.wilwerth@gmail.com>
Co-authored-by: oyvindln <oyvindln@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oyvindln oyvindln Awaiting requested review from oyvindln

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VideoMem @oyvindln