Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVBS improvements, supergauss, debug_plots, sub-deemphasis, S-VHS, filter-plot improvements #127

Merged
merged 6 commits into from
Feb 4, 2024

Conversation

Stefan-Olt
Copy link

Implemented a CVBS automatic gain adjustment / clamping:

  • It will take the sync and the black level after time-base-correction as reference
  • It will calculate the median of all blank and sync levels of all lines (except top/bottom) to calculate the gain for the entire field
  • The gain is averaged over time
  • It will clamp based an on the median of the blank level of the line and 2 last and 2 next lines (to compensate for dropouts)
  • The sync/blank levels of the last field are used for sync detection of the next field
  • Added options: Enable this functionality, set gain multiplier, set fixed gain, set gain average speed

vhs-decode:

  • Two new debug_plots: luma rf filter and magnitude/density over frequency histogram (as proposed by novgorod)
  • Implemeted supergauss (as proposed by novgorod) for luma rf filtering to reduce ringing
  • Added option for additional (linear) custom video filters to apply to luma signal
  • Added custom filter for S-VHS based sub-deemphasis as shown in service manual
  • Tuned sub-demphasis values for S-VHS
  • Added option for logistic scaling of sub-deemphasis amplitude

Filter-plot:

  • Removed old SVHS-specific experiment
  • Added reference values to plot (only S-VHS at the moment, but designed for other formats to be added, can optionally include custom filters and main deemphasis)
  • Added QSplitter to make image and plot division adjustable with mouse

@Stefan-Olt
Copy link
Author

What is not working correctly is the installation: The two txt files with the filter tables for S-VHS custom filter is not copied by pipx. Not sure if they should be in another directory, but should be sorted out when merging this changes, but I have no idea how pipx works.

@oyvindln
Copy link
Owner

oyvindln commented Feb 4, 2024

Yeah I can sort that afterwards, has to be set up in pyproject.toml

@oyvindln oyvindln merged commit 11d9342 into oyvindln:vhs_decode Feb 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants