Turn off native insertHTML command for Edge (too buggy for now)

oyeanuj · Feb 7, 2016 · 62cd678 · 62cd678
1 parent a711034
commit 62cd678
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 15 deletions.
diff --git a/spec/paste.spec.js b/spec/paste.spec.js
@@ -72,8 +72,7 @@ describe('Pasting content', function () {
             {
                 source: 'Text single word with leading/trailing space',
                 paste: ' supercalifragilisticexpalidocious ',
-                // Edge incorrectly remove the leading whitespace >:(
-                output: isEdge() ? '<div id="editor-inner">supercalifragilisticexpalidocious </div>' : '<div id="editor-inner"> supercalifragilisticexpalidocious </div>'
+                output: '<div id="editor-inner"> supercalifragilisticexpalidocious </div>'
             },
             {
                 source: 'Text multi-word with no line breaks',
@@ -282,14 +281,7 @@ describe('Pasting content', function () {
             selectElementContents(document.getElementById('editor-inner'));
 
             editor.cleanPaste('<label>div one</label><label>div two</label>');
-
-            // Edge adds a <font size="2"> tag in here!?!?!
-            // TODO: Is this just completely wrong?
-            if (isEdge()) {
-                expect(this.el.innerHTML).toEqual('Before&nbsp;<span id="editor-inner"><sub><font size="2">div one</font></sub><sub>div two</sub></span>&nbsp;after.');
-            } else {
-                expect(this.el.innerHTML).toMatch(new RegExp('^Before(&nbsp;|\\s)(<span id="editor-inner">)?<sub>div one</sub><sub>div two</sub>(</span>)?(&nbsp;|\\s)after\\.$'));
-            }
+            expect(this.el.innerHTML).toMatch(new RegExp('^Before(&nbsp;|\\s)(<span id="editor-inner">)?<sub>div one</sub><sub>div two</sub>(</span>)?(&nbsp;|\\s)after\\.$'));
         });
 
         it('should respect custom replacements before builtin replacements.', function () {

diff --git a/src/js/core.js b/src/js/core.js
@@ -35,9 +35,7 @@
 
         if (tag === 'pre') {
             event.preventDefault();
-            // Edge doesn't allow for adding leading whitespace via the 'insertHTML' command
-            // so for Edge, we'll have to inject the 'tab' manually
-            MediumEditor.util.insertHTMLCommand(this.options.ownerDocument, '    ', MediumEditor.util.isEdge);
+            MediumEditor.util.insertHTMLCommand(this.options.ownerDocument, '    ');
         }
 
         // Tab to indent list structures!

diff --git a/src/js/util.js b/src/js/util.js
@@ -436,10 +436,17 @@
         },
 
         // http://stackoverflow.com/questions/6690752/insert-html-at-caret-in-a-contenteditable-div
-        insertHTMLCommand: function (doc, html, skipExecCommand) {
+        insertHTMLCommand: function (doc, html) {
             var selection, range, el, fragment, node, lastNode, toReplace;
 
-            if (!skipExecCommand && doc.queryCommandSupported('insertHTML')) {
+            /* Edge's implementation of insertHTML is just buggy right now:
+             * - Doesn't allow leading white space at the beginning of an element
+             * - Found a case when a <font size="2"> tag was inserted when calling alignCenter inside a blockquote
+             *
+             * There are likely many other bugs, these are just the ones we found so far.
+             * For now, let's just use the same fallback we did for IE
+             */
+            if (!MediumEditor.util.isEdge && doc.queryCommandSupported('insertHTML')) {
                 try {
                     return doc.execCommand('insertHTML', false, html);
                 } catch (ignore) {}