Change default event triggered for selectElementContentsAndFire helper

oyeanuj · Feb 9, 2016 · 5a0fd76 · 5a0fd76
1 parent b2cf29d
commit 5a0fd76
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/spec/anchor-preview.spec.js b/spec/anchor-preview.spec.js
@@ -248,7 +248,7 @@ describe('Anchor Preview TestCase', function () {
             anchorPreview = editor.getExtensionByName('anchor-preview'),
             toolbar = editor.getExtensionByName('toolbar');
 
-            selectElementContentsAndFire(editor.elements[0].firstChild, { eventToFire: 'click' });
+            selectElementContentsAndFire(editor.elements[0].firstChild);
 
             // show preview
             spyOn(MediumEditor.extensions.anchorPreview.prototype, 'showPreview').and.callThrough();

diff --git a/spec/extension.spec.js b/spec/extension.spec.js
@@ -324,7 +324,7 @@ describe('Extensions TestCase', function () {
                         'dummy': ExtensionWithElement
                     }
                 });
-            selectElementContentsAndFire(editor.elements[0].firstChild);
+            selectElementContentsAndFire(editor.elements[0].firstChild, { eventToFire: 'focus' });
             spyOn(ExtensionWithElement, 'checkState').and.callThrough();
             editor.checkSelection();
             jasmine.clock().tick(51);

diff --git a/spec/helpers/util.js b/spec/helpers/util.js
@@ -220,5 +220,5 @@ function selectElementContents(el, options) {
 function selectElementContentsAndFire(el, options) {
     options = options || {};
     selectElementContents(el, options);
-    fireEvent(el, options.eventToFire || 'focus');
+    fireEvent(el, options.eventToFire || 'click');
 }
diff --git a/spec/setup.spec.js b/spec/setup.spec.js
@@ -112,16 +112,16 @@ describe('Setup/Destroy TestCase', function () {
 
             spyOn(toolbar, 'hideToolbar').and.callThrough(); // via: handleBlur
 
-            selectElementContentsAndFire(editor.elements[0], { eventToFire: 'click' });
+            selectElementContentsAndFire(editor.elements[0]);
             jasmine.clock().tick(51);
             expect(toolbar.hideToolbar).not.toHaveBeenCalled();
 
-            selectElementContentsAndFire(editor.elements[1], { eventToFire: 'click' });
+            selectElementContentsAndFire(editor.elements[1]);
             jasmine.clock().tick(51);
             expect(toolbar.hideToolbar).not.toHaveBeenCalled();
 
             selectElementContents(editor.elements[2]);
-            selectElementContentsAndFire(editor.elements[2], { eventToFire: 'click' });
+            selectElementContentsAndFire(editor.elements[2]);
             jasmine.clock().tick(51);
             expect(toolbar.hideToolbar).not.toHaveBeenCalled();
 

diff --git a/spec/toolbar.spec.js b/spec/toolbar.spec.js
@@ -333,7 +333,7 @@ describe('MediumEditor.extensions.toolbar TestCase', function () {
                 }),
                 toolbar = editor.getExtensionByName('toolbar');
 
-            selectElementContentsAndFire(this.el.querySelector('b'));
+            selectElementContentsAndFire(this.el.querySelector('b'), { eventToFire: 'focus' });
             window.getSelection().removeAllRanges();
             editor.checkSelection();
             jasmine.clock().tick(1); // checkSelection delay
@@ -352,7 +352,7 @@ describe('MediumEditor.extensions.toolbar TestCase', function () {
                 }),
                 toolbar = editor.getExtensionByName('toolbar');
 
-            selectElementContentsAndFire(this.el.querySelector('b'));
+            selectElementContentsAndFire(this.el.querySelector('b'), { eventToFire: 'focus' });
             window.getSelection().removeAllRanges();
             editor.checkSelection();
             jasmine.clock().tick(1); // checkSelection delay