Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP PHIVE: Use keys.openpgp.org and fingerprint for phive key verification #3230

Merged
merged 4 commits into from
Dec 17, 2023

Conversation

echoix
Copy link
Collaborator

@echoix echoix commented Dec 16, 2023

Matches the current PHIVE installation instructions

Should fix transient php installation failures

Proposed Changes

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@echoix
Copy link
Collaborator Author

echoix commented Dec 16, 2023

/build

Command run output
Build command workflow started.
Installing dependencies
Running script ./build.sh
Build command workflow completed updating files.

Copy link
Contributor

github-actions bot commented Dec 16, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 5 0 0.01s
✅ BASH shellcheck 5 0 0.09s
✅ BASH shfmt 5 0 0 0.52s
✅ COPYPASTE jscpd yes no 4.46s
✅ DOCKERFILE hadolint 127 0 11.87s
✅ JSON eslint-plugin-jsonc 23 0 0 4.18s
✅ JSON jsonlint 21 0 0.26s
✅ JSON v8r 23 0 19.95s
✅ MAKEFILE checkmake 1 0 0.01s
⚠️ MARKDOWN markdownlint 259 0 265 29.89s
✅ MARKDOWN markdown-link-check 259 0 8.58s
✅ MARKDOWN markdown-table-formatter 259 0 0 67.1s
✅ OPENAPI spectral 1 0 1.69s
⚠️ PYTHON bandit 206 59 3.19s
✅ PYTHON black 206 0 0 4.56s
✅ PYTHON flake8 206 0 1.62s
✅ PYTHON isort 206 0 0 1.63s
✅ PYTHON mypy 206 0 14.98s
✅ PYTHON pylint 206 0 16.85s
⚠️ PYTHON pyright 206 346 27.64s
✅ PYTHON ruff 206 0 0 0.66s
✅ REPOSITORY checkov yes no 38.9s
✅ REPOSITORY git_diff yes no 0.45s
⚠️ REPOSITORY grype yes 1 23.79s
✅ REPOSITORY secretlint yes no 12.47s
✅ REPOSITORY trivy yes no 31.77s
✅ REPOSITORY trivy-sbom yes no 24.19s
⚠️ REPOSITORY trufflehog yes 1 16.96s
✅ SPELL cspell 679 0 30.97s
✅ SPELL lychee 339 0 25.0s
✅ XML xmllint 3 0 0 0.51s
✅ YAML prettier 160 0 0 6.88s
✅ YAML v8r 102 0 158.77s
✅ YAML yamllint 161 0 1.97s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only update in this PR is the changelog file ^^

@echoix
Copy link
Collaborator Author

echoix commented Dec 16, 2023

I didn't find another place that had the phive installation text, so I thought it was the Dockerfile the ground truth. Seems it got overwritten while building. You can check the first commit. Where should it be changed? (I also changed the order of the servers to the main one, next the other live, and the slowest at the end. Removed the dead one.)

@nvuillam
Copy link
Member

@echoix it's here :)

RUN GITHUB_AUTH_TOKEN="$(cat /run/secrets/GITHUB_TOKEN)" \

echoix and others added 4 commits December 17, 2023 14:21
…ation

Matches the current PHIVE installation instructions
* [automation] Auto-update linters version, help and documentation

* [MegaLinter] Apply linters fixes

---------

Co-authored-by: nvuillam <nvuillam@users.noreply.github.com>
@nvuillam nvuillam merged commit e7281f8 into main Dec 17, 2023
130 checks passed
@nvuillam nvuillam deleted the phive-gpg-keyserver branch December 17, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants