-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatters-only flavor #2921
Comments
The idea looks interesting :) And as we have a is_formatter property on linter descriptors, it should be doable :) cc @Kurt-von-Laven @bdovaz @echoix what do you think ? |
@withinfocus, are you already aware of the |
@Kurt-von-Laven yes indeed and that's what we have in place today, but it can still output results that are not formatting-related and potentially block a commit. We desire format-only to require success from Mega-Linter and allow potentially-subjective results from non-formatters to run later and not block commit (or even merge, such as during PR review). |
In that case, I can't think of a better solution than a formatter-only flavor. |
I'd be interested in knowing for now, if the difference in image size would be worth building that additionnal flavor constantly, vs just deactivating the unneeded flavors. I expect that the set of linters change someday, but maybe we are quite close with what we have. Let's measure it with a proof of concept! |
A flavor is one option but I thought that easier to implement than another configuration variable during invocation. If it's better for the product to have a |
We probably can handle both: a Formatters flavor + an option to run only formatters in any MegaLinter flavor, including the big one :) |
We could rename |
This issue has been automatically marked as stale because it has not had recent activity. If you think this issue should stay open, please remove the |
Still desired! |
@withinfocus the backlog is big, and the available time is thin , you are right to post a reminder ;) |
This issue has been automatically marked as stale because it has not had recent activity. If you think this issue should stay open, please remove the |
Still desired! |
Fixes #2921 Co-authored-by: Matt Bishop <1046132+withinfocus@users.noreply.github.com>
@withinfocus it's on the way :) |
* [automation] Auto-update linters version, help and documentation * trvy * New formatters flavor Fixes #2921 Co-authored-by: Matt Bishop <1046132+withinfocus@users.noreply.github.com> * [MegaLinter] Apply linters fixes --------- Co-authored-by: nvuillam <nvuillam@users.noreply.github.com>
@withinfocus the formatter flavor is available in beta :) |
Amazing! We'll try this out shortly. |
This is successfully working in a private template repository. Anything we can help with to get this to leave beta? Testing was light but given the "is formatter" flag being the one real change used here it seems pretty safe to be considered stable. |
@withinfocus it will be in the next minor release :) |
Is your feature request related to a problem? Please describe.
We desire a dual-use model of Mega-Linter as a pre-commit hook and a GitHub action, with the separation being formatters-only with the former and the entire suite with the latter. Put another way, we only want to address matters that are format-related locally, ideally with autofixing, to keep commits reasonably fast.
Describe the solution you'd like
A flavor that is only formatters -- and not overall linters -- to run with
mega-linter-runner
.Describe alternatives you've considered
A combination of other settings, but we still have too much running locally that we'd like to defer to later.
The text was updated successfully, but these errors were encountered: