Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

humility ibc black-box should skip empty events #434

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Conversation

citrus-it
Copy link
Contributor

@citrus-it citrus-it commented Nov 22, 2023

Fixes #433

jeeves% ./humility ibc black-box
FAULT EVENT
  EVENT_INDEX:        0
  EMPTY
LIFECYCLE EVENT
  EVENT_INDEX:        24
  TIMESTAMP           0xffd5872f = 3 day, 5 hr, 19 min, 4.0 sec
  EVENT_ID            0x0350
  STATUS_WORD         0x0001
    0x0001: System event
  STATUS_MFR          0x05
    0x05: ERASE_OVFL_EVENT
  V_IN                0xf86c = 54.000V
  V_OUT               0x0000 = 0.000V
  I_OUT               0x07ff = -1.000A
  TEMPERATURE         0x0013 = 19.000°C

Copy link
Contributor

@bcantrill bcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies for the delay on this review! This looks good -- I experimented with different ways to factor it (in particular, to avoid mutable state being passed as a parameter), but I'm not convinced that the result is much cleaner. Pulling this in -- thank you!

@bcantrill bcantrill merged commit 8a8922a into master Dec 13, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

humility ibc black-box should skip empty events
2 participants