test(ast/estree): ESTree conformance runner skip tests we cannot pass #9073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merge activity
|
…#9073) ESTree conformance tester ignore tests which we cannot parse at present due to #3526 and #9029. I've have checked all these tests one-by-one and made sure that their failures are all due to either #3526 and #9029. Ignoring these tests results in 100% passing. Really we shouldn't skip these tests because they should pass and they don't. But I intend to break everything again shortly by making the conformance tester stricter - e.g. make it insist fields be in same order as Acorn - so it'll be helpful to be able to see when we've fixed all those failures again, without having to filter out these "known bad" tests.
ea45855 to
c240141
Compare
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESTree conformance tester ignore tests which we cannot parse at present due to #3526 and #9029.
I've have checked all these tests one-by-one and made sure that their failures are all due to either #3526 and #9029.
Ignoring these tests results in 100% passing.
Really we shouldn't skip these tests because they should pass and they don't. But I intend to break everything again shortly by making the conformance tester stricter - e.g. make it insist fields be in same order as Acorn - so it'll be helpful to be able to see when we've fixed all those failures again, without having to filter out these "known bad" tests.