Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ast): estree compat UnaryExpression #8973

Merged
merged 1 commit into from
Feb 9, 2025
Merged

fix(ast): estree compat UnaryExpression #8973

merged 1 commit into from
Feb 9, 2025
+4 −2,999

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Feb 8, 2025 •
edited
Loading

Part of #2854

difff os estree_test262.snap

-Positive Passed: 13042/44293 (29.44%)
+Positive Passed: 16040/44293 (36.21%)

@github-actions github-actions bot added the A-ast Area - AST label Feb 8, 2025
@hi-ogawa Graphite App
Copy link
Contributor Author

hi-ogawa commented Feb 8, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Feb 8, 2025
Merged
Merged
@hi-ogawa hi-ogawa changed the title fix: estree compat Function.expression and UnaryExpression.prefix fix(ast): estree compat UnaryExpression Feb 8, 2025
@hi-ogawa hi-ogawa mentioned this pull request Feb 8, 2025
Merged
@github-actions github-actions bot added the C-bug Category - Bug label Feb 8, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 8, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8973 will not alter performance

Comparing ast-estree-unary-prefix (801d78e) with main (a1ca2eb)

Summary

✅ 33 untouched benchmarks

@hi-ogawa hi-ogawa changed the base branch from fix-ast-estree-function to graphite-base/8973 February 8, 2025 06:54
@hi-ogawa hi-ogawa mentioned this pull request Feb 8, 2025
Merged
@hi-ogawa hi-ogawa force-pushed the ast-estree-unary-prefix branch 3 times, most recently from 15e6781 to ac4457c Compare February 9, 2025 03:02
@hi-ogawa hi-ogawa marked this pull request as ready for review February 9, 2025 03:15
@hi-ogawa hi-ogawa mentioned this pull request Feb 9, 2025
Open
@Boshen Boshen force-pushed the graphite-base/8973 branch from e5ab419 to 2315309 Compare February 9, 2025 04:20
@Boshen Boshen force-pushed the ast-estree-unary-prefix branch from ac4457c to 0081ddd Compare February 9, 2025 04:20
@Boshen Boshen changed the base branch from graphite-base/8973 to fix-ast-estree-function February 9, 2025 04:20
@Boshen Boshen force-pushed the ast-estree-unary-prefix branch from 0081ddd to 7ddee17 Compare February 9, 2025 04:20
@overlookmotel overlookmotel changed the base branch from fix-ast-estree-function to graphite-base/8973 February 9, 2025 18:53
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Feb 9, 2025
@overlookmotel Graphite App
Copy link
Contributor

overlookmotel commented Feb 9, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Feb 9, 1:53 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 9, 1:53 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 9, 1:59 PM EST: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Feb 9, 2:00 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 9, 2:00 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 9, 2:01 PM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Feb 9, 2:45 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 9, 2:45 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 9, 2:50 PM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot changed the base branch from graphite-base/8973 to main February 9, 2025 18:58
@graphite-app graphite-app bot added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Feb 9, 2025
@overlookmotel overlookmotel force-pushed the ast-estree-unary-prefix branch from 7ddee17 to 47fd570 Compare February 9, 2025 19:00
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 9, 2025
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Feb 9, 2025
@hi-ogawa
fix(ast): estree compat UnaryExpression (#8973)
801d78e 
Part of #2854

difff os estree_test262.snap

```diff
-Positive Passed: 13042/44293 (29.44%)
+Positive Passed: 16040/44293 (36.21%)
```
@graphite-app graphite-app bot force-pushed the ast-estree-unary-prefix branch from 47fd570 to 801d78e Compare February 9, 2025 19:45
@graphite-app graphite-app bot merged commit 801d78e into main Feb 9, 2025
25 checks passed
@graphite-app graphite-app bot deleted the ast-estree-unary-prefix branch February 9, 2025 19:50
Dunqing pushed a commit that referenced this pull request Feb 10, 2025
@hi-ogawa @Dunqing
fix(ast): estree compat UnaryExpression (#8973)
5d371ca 
Part of #2854

difff os estree_test262.snap

```diff
-Positive Passed: 13042/44293 (29.44%)
+Positive Passed: 16040/44293 (36.21%)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overlookmotel overlookmotel overlookmotel approved these changes

Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST C-bug Category - Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hi-ogawa @overlookmotel